Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Balance] fetch historical balance #140

Closed
wants to merge 14 commits into from
Closed

[Balance] fetch historical balance #140

wants to merge 14 commits into from

Conversation

xinyu-li-cb
Copy link
Contributor

  • init
  • update tests with usd_value
  • tests
  • api.ts updates
  • fix test
  • update change log
  • [Balance] fetch historical balance

What changed? Why?

Qualified Impact

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

1 similar comment
@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@xinyu-li-cb xinyu-li-cb changed the base branch from master to v0.0.15 August 9, 2024 00:20
@xinyu-li-cb xinyu-li-cb changed the title historicalbalance [Balance] fetch historical balance Aug 9, 2024
@xinyu-li-cb xinyu-li-cb marked this pull request as ready for review August 9, 2024 00:25
xinyu-li-cb
xinyu-li-cb commented Aug 9, 2024
View reviewed changes
src/coinbase/address.ts
@@ -13,6 +14,8 @@ import { StakingReward } from "./staking_reward";
* A representation of a blockchain address, which is a user-controlled account on a network.
*/
export class Address {
private static MAX_HISTORICAL_BALANCE = 1000;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick a magic number for fetching all historical balance (fetch without page parameters).

John-peterson-coinbase
John-peterson-coinbase reviewed Aug 9, 2024
View reviewed changes
src/tests/external_address_test.ts Outdated Show resolved Hide resolved
src/coinbase/address.ts Outdated Show resolved Hide resolved
@John-peterson-coinbase John-peterson-coinbase deleted the branch v0.0.15 August 12, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinyu-li-cb @cb-heimdall @John-peterson-coinbase