Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Balance] fetch address historical balance #133

Closed
wants to merge 13 commits into from

Conversation

xinyu-li-cb
Copy link
Contributor

What changed? Why?

Add function to fetch address historical balance

Qualified Impact

@cb-heimdall
Copy link

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

package.json Outdated
@@ -4,7 +4,7 @@
"license": "ISC",
"description": "Coinbase Platform SDK",
"repository": "https://github.com/coinbase/coinbase-sdk-nodejs",
"version": "0.0.14",
"version": "0.0.12",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to revert this line. it should be 0.0.14>

src/client/common.ts Show resolved Hide resolved
@erdimaden erdimaden changed the base branch from master to v0.0.15 August 8, 2024 20:03
src/tests/historical_balance_test.ts Outdated Show resolved Hide resolved
src/tests/historical_balance_test.ts Outdated Show resolved Hide resolved
src/coinbase/address.ts Outdated Show resolved Hide resolved
@xinyu-li-cb xinyu-li-cb marked this pull request as ready for review August 8, 2024 22:50
@xinyu-li-cb xinyu-li-cb closed this Aug 9, 2024
* @param page - A cursor for pagination across multiple pages of results. Don\'t include this parameter on the first call. Use the next_page value returned in a previous response to request subsequent results.
* @returns The list of historical balance of the asset and next page token.
*/
public async listHistoricalBalance(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

listHistoricalBalances since we're returning a list of historical balances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants