stone's comments

src/coinbase/sponsored_send.ts

@@ -34,7 +34,7 @@ export class SponsoredSend {
   /**
    * Returns the signature of the typed data.
    *
-   * @returns The Keccak256 hash of the typed data.
+   * @returns The hash of the typed data signature.
    */
   getSignature(): string | undefined {
     return this.model.signature;
@@ -50,8 +50,7 @@ export class SponsoredSend {
     ethers.toBeArray;
     const signature = key.signingKey.sign(ethers.getBytes(this.getTypedDataHash())).serialized;
     this.model.signature = signature;
-    // Removes the '0x' prefix as required by the API.
-    return signature.slice(2);
+    return signature;
   }
 
   /**
@@ -60,7 +59,7 @@ export class SponsoredSend {
    * @returns if the Sponsored Send has been signed.
    */
   isSigned(): boolean {
-    return this.getSignature() ? true : false;
+    return !!this.getSignature();
   }
 
   /**
@@ -92,9 +91,10 @@ export class SponsoredSend {
    */
   isTerminalState(): boolean {
     const status = this.getStatus();
-    return !status
-      ? false
-      : [SponsoredSendStatus.COMPLETE, SponsoredSendStatus.FAILED].includes(status);
+
+    if (!status) return false;
+
+    return [SponsoredSendStatus.COMPLETE, SponsoredSendStatus.FAILED].includes(status);
   }
 
   /**

src/coinbase/transaction.ts

@@ -86,9 +86,10 @@ export class Transaction {
    */
   isTerminalState(): boolean {
     const status = this.getStatus();
-    return !status
-      ? false
-      : [TransactionStatus.COMPLETE, TransactionStatus.FAILED].includes(status);
+
+    if (!status) return false;
+
+    return [TransactionStatus.COMPLETE, TransactionStatus.FAILED].includes(status);
   }
 
   /**
@@ -145,7 +146,7 @@ export class Transaction {
    * @returns The Signed Payload
    */
   getSignature(): string | undefined {
-    return this.getSignedPayload();
+    return this.getSignedPayload()?.slice(2);
   }
 
   /**
@@ -154,7 +155,7 @@ export class Transaction {
    * @returns if the transaction has been signed.
    */
   isSigned(): boolean {
-    return this.getSignature() ? true : false;
+    return !!this.getSignature();
   }
 
   /**

src/coinbase/transfer.ts

@@ -213,7 +213,7 @@ export class Transfer {
       throw new Error("Cannot broadcast unsigned Transfer");
 
     const broadcastTransferRequest = {
-      signed_payload: this.getSendTransactionDelegate()!.getSignature()!.slice(2),
+      signed_payload: this.getSendTransactionDelegate()!.getSignature()!,
     };
 
     const response = await Coinbase.apiClients.transfer!.broadcastTransfer(

src/tests/sponsored_send_test.ts

@@ -121,7 +121,7 @@ describe("SponsoredSend", () => {
     });
 
     it("sets the signature", () => {
-      expect(sponsoredSend.getSignature().slice(2)).toEqual(signature);
+      expect(sponsoredSend.getSignature()).toEqual(signature);
     });
   });
 

src/tests/transfer_test.ts

@@ -364,7 +364,7 @@ describe("Transfer Class", () => {
         },
       });
       const signature = await transfer.sign(signingKey);
-      expect(signature).toEqual(transfer.getTransaction()!.getSignature()!.slice(2));
+      expect(signature).toEqual(transfer.getTransaction()!.getSignature()!);
     });
   });