Adding requested feedback

coinbase · Jun 6, 2024 · 3bbec8c · 3bbec8c
1 parent cd45852
commit 3bbec8c
Show file tree

Hide file tree

Showing 10 changed files with 92 additions and 57 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,12 +1,18 @@
 # Coinbase Node.js SDK Changelog
 
+## [0.0.7] - 2024-06-03
+
+### Changed
+Updated the usage of `Coinbase.networkList` to `Coinbase.networks`
+
 ## [0.0.6] - 2024-06-03
 
 ### Added
 
 - Ability to create wallets backed by server signers and transfer with them
 - Changed save_wallet to save_seed
 - Changed load_wallets to load_seed and moved at wallet level
+- Adding Base Mainnet network support
 
 ### Changed
 

diff --git a/src/coinbase/coinbase.ts b/src/coinbase/coinbase.ts
@@ -25,7 +25,7 @@ export class Coinbase {
    *
    * @constant
    */
-  static networkList = {
+  static networks = {
     BaseSepolia: "base-sepolia",
     BaseMainnet: "base-mainnet",
   };

diff --git a/src/coinbase/tests/address_test.ts b/src/coinbase/tests/address_test.ts
@@ -37,7 +37,7 @@ describe("Address", () => {
         amount: "1000000000000000000",
         asset: {
           asset_id,
-          network_id: Coinbase.networkList.BaseSepolia,
+          network_id: Coinbase.networks.BaseSepolia,
         },
       };
       return { data: balanceModel };
@@ -198,7 +198,7 @@ describe("Address", () => {
           amount: "1000000000000000000",
           asset: {
             asset_id,
-            network_id: Coinbase.networkList.BaseSepolia,
+            network_id: Coinbase.networks.BaseSepolia,
           },
         };
         return { data: balanceModel };

diff --git a/src/coinbase/tests/balance_map_test.ts b/src/coinbase/tests/balance_map_test.ts
@@ -16,23 +16,23 @@ describe("BalanceMap", () => {
     const ethBalanceModel: BalanceModel = {
       asset: {
         asset_id: Coinbase.assets.Eth,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
       },
       amount: ethAtomicAmount,
     };
 
     const usdcBalanceModel: BalanceModel = {
       asset: {
         asset_id: "usdc",
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
       },
       amount: usdcAtomicAmount,
     };
 
     const wethBalanceModel: BalanceModel = {
       asset: {
         asset_id: "weth",
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
       },
       amount: wethAtomicAmount,
     };
@@ -53,7 +53,7 @@ describe("BalanceMap", () => {
     const balance = Balance.fromModelAndAssetId(
       {
         amount: ethAtomicAmount,
-        asset: { asset_id: assetId, network_id: Coinbase.networkList.BaseSepolia },
+        asset: { asset_id: assetId, network_id: Coinbase.networks.BaseSepolia },
       },
       assetId,
     );
@@ -71,7 +71,7 @@ describe("BalanceMap", () => {
     const balance = Balance.fromModelAndAssetId(
       {
         amount: ethAtomicAmount,
-        asset: { asset_id: assetId, network_id: Coinbase.networkList.BaseSepolia },
+        asset: { asset_id: assetId, network_id: Coinbase.networks.BaseSepolia },
       },
       assetId,
     );

diff --git a/src/coinbase/tests/balance_test.ts b/src/coinbase/tests/balance_test.ts
@@ -10,7 +10,7 @@ describe("Balance", () => {
       amount: "1000000000000000000",
       asset: {
         asset_id: Coinbase.assets.Eth,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
       },
     };
 
@@ -28,7 +28,7 @@ describe("Balance", () => {
   describe(".fromModelAndAssetId", () => {
     const amount = new Decimal(1);
     const balanceModel: BalanceModel = {
-      asset: { asset_id: Coinbase.assets.Eth, network_id: Coinbase.networkList.BaseSepolia },
+      asset: { asset_id: Coinbase.assets.Eth, network_id: Coinbase.networks.BaseSepolia },
       amount: "1000000000000000000",
     };
 

diff --git a/src/coinbase/tests/coinbase_test.ts b/src/coinbase/tests/coinbase_test.ts
@@ -86,12 +86,12 @@ describe("Coinbase tests", () => {
 
       const walletModel = {
         id: walletId,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         default_address: {
           wallet_id: walletId,
           address_id: addressId,
           public_key: publicKey,
-          network_id: Coinbase.networkList.BaseSepolia,
+          network_id: Coinbase.networks.BaseSepolia,
         },
       };
 

diff --git a/src/coinbase/tests/user_test.ts b/src/coinbase/tests/user_test.ts
@@ -69,7 +69,7 @@ describe("User Class", () => {
       };
       mockWalletModel = {
         id: walletId,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         default_address: mockAddressModel,
         enabled_features: [],
       };
@@ -116,7 +116,7 @@ describe("User Class", () => {
       const addressModel2: AddressModel = newAddressModel(walletId);
       walletModelWithDefaultAddress = {
         id: walletId,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         default_address: addressModel1,
         enabled_features: [],
       };
@@ -253,7 +253,7 @@ describe("User Class", () => {
         amount: "5000000000000000000",
         asset: {
           asset_id: Coinbase.assets.Eth,
-          network_id: Coinbase.networkList.BaseSepolia,
+          network_id: Coinbase.networks.BaseSepolia,
           decimals: 18,
         },
       };
@@ -273,7 +273,7 @@ describe("User Class", () => {
       const wallet = result.wallets[0];
       expect(wallet.getId()).toBe(walletId);
       expect(wallet.canSign()).toBe(false);
-      expect(wallet.getNetworkId()).toBe(Coinbase.networkList.BaseSepolia);
+      expect(wallet.getNetworkId()).toBe(Coinbase.networks.BaseSepolia);
       expect(wallet.getDefaultAddress()?.getId()).toBe(
         walletModelWithDefaultAddress.default_address?.address_id,
       );
@@ -309,7 +309,7 @@ describe("User Class", () => {
       const addressModel2: AddressModel = newAddressModel(walletId);
       walletModelWithDefaultAddress = {
         id: walletId,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         default_address: addressModel1,
         enabled_features: [],
       };

diff --git a/src/coinbase/tests/utils.ts b/src/coinbase/tests/utils.ts
@@ -55,7 +55,7 @@ export const newAddressModel = (walletId: string, address_id: string = ""): Addr
 
   return {
     address_id: address_id ? address_id : ethAddress.address,
-    network_id: Coinbase.networkList.BaseSepolia,
+    network_id: Coinbase.networks.BaseSepolia,
     public_key: ethAddress.publicKey,
     wallet_id: walletId,
   };
@@ -65,19 +65,19 @@ export const VALID_ADDRESS_MODEL = newAddressModel(randomUUID());
 
 export const VALID_WALLET_MODEL: WalletModel = {
   id: randomUUID(),
-  network_id: Coinbase.networkList.BaseSepolia,
+  network_id: Coinbase.networks.BaseSepolia,
   enabled_features: [],
   default_address: {
     wallet_id: walletId,
     address_id: "0xdeadbeef",
     public_key: "0x1234567890",
-    network_id: Coinbase.networkList.BaseSepolia,
+    network_id: Coinbase.networks.BaseSepolia,
   },
 };
 
 export const VALID_TRANSFER_MODEL: TransferModel = {
   transfer_id: transferId,
-  network_id: Coinbase.networkList.BaseSepolia,
+  network_id: Coinbase.networks.BaseSepolia,
   wallet_id: walletId,
   address_id: ethers.Wallet.createRandom().address,
   destination: "0x4D9E4F3f4D1A8B5F4f7b1F5b5C7b8d6b2B3b1b0b",
@@ -103,23 +103,23 @@ export const VALID_ADDRESS_BALANCE_LIST: AddressBalanceList = {
       amount: "1000000000000000000",
       asset: {
         asset_id: Coinbase.assets.Eth,
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         decimals: 18,
       },
     },
     {
       amount: "5000000000",
       asset: {
         asset_id: "usdc",
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         decimals: 6,
       },
     },
     {
       amount: "3000000000000000000",
       asset: {
         asset_id: "weth",
-        network_id: Coinbase.networkList.BaseSepolia,
+        network_id: Coinbase.networks.BaseSepolia,
         decimals: 6,
       },
     },
@@ -133,7 +133,7 @@ export const VALID_BALANCE_MODEL: BalanceModel = {
   amount: "1000000000000000000",
   asset: {
     asset_id: Coinbase.assets.Eth,
-    network_id: Coinbase.networkList.BaseSepolia,
+    network_id: Coinbase.networks.BaseSepolia,
   },
 };