Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add explicit template type args for ActionProvider<...> ext #270

Merged
merged 1 commit into from
Feb 5, 2025
Merged

chore: Add explicit template type args for ActionProvider<...> ext #270

merged 1 commit into from
Feb 5, 2025

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Fixed ActionProvider<...> type extensions to include template type argument

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Feb 5, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link

Review Error for stat @ 2025-02-05 18:30:51 UTC
User failed mfa authentication, see go/mfa-help

@stat stat self-requested a review February 5, 2025 18:31
@John-peterson-coinbase John-peterson-coinbase merged commit 56f2c44 into master Feb 5, 2025
19 checks passed
@John-peterson-coinbase John-peterson-coinbase deleted the chore-add-template-type-args-for-action-provider-ext branch February 5, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stat stat stat approved these changes

@0xRAG 0xRAG Awaiting requested review from 0xRAG

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @stat