Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types and make wallet providers more flexible #264

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Improve types and make wallet providers more flexible #264

wants to merge 3 commits into from

Conversation

gskril
Copy link

@gskril gskril commented Feb 5, 2025 •
edited
Loading

What changed? Why?

Replaced all cases of 0x${string} with Hex from Viem for cleanliness.

Also fixed the response type of waitForTransactionReceipt() in a few wallet providers.

Qualified Impact

Exposes publicClient and walletClient from VieimWalletProvider to allow more custom provider flexibility, since not all viem methods are explicitly included in the class.

Closes #272

@cb-heimdall
Copy link

cb-heimdall commented Feb 5, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@gskril gskril changed the title Clean up Hex types and improve response types Improve types and make wallet providers more flexible Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose viem public client actions from ViemWalletProvider
2 participants
@gskril @cb-heimdall