Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

coinbase / MagicSpend Public

Notifications You must be signed in to change notification settings
Fork 14
Star 95

Code
Issues
Pull requests
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

Gas optimizations from the Code4rena audit#18

Merged

stevieraykatz merged 6 commits intomaincoinbase/MagicSpend:mainfrom gas-optimizationscoinbase/MagicSpend:gas-optimizationsCopy head branch name to clipboard

Apr 4, 2024

+18-18

Conversation Commits6 (6)Checks Files changed

Commits

Commits on Apr 4, 2024

Check that withdrawAmt > maxCost before updating mapping. Per code-423n4/2024-03-coinbase-findings#195 , G04
stevieraykatz
committed
Switch validation checks for gas optimization. Per code-423n4/2024-03-coinbase-findings#195 G06
stevieraykatz
committed
Reorder validations in withdraw to check signature before validating the full request. Per code-423n4/2024-03-coinbase-findings#137 G02
stevieraykatz
committed
Added gas snapshot
stevieraykatz
committed
Formatted
stevieraykatz
committed
Remove balance check before updating withdrawable mapping, rerun snapshot
stevieraykatz
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.