Fixing some typos and adding ability to add service account to toolki… #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnitedata/toolkit into service_account_toolkit_group
doctrino
requested changes
Jan 17, 2025
| self.warn( | ||
| HighSeverityWarning( | ||
| f"The source id {source_id!r} is already used by the groups: {humanize_collection(already_used)!r}." | ||
| auth_vars = AuthVariables.from_env() |
There was a problem hiding this comment.
This assumes that the credentials you are currently using are the ones you should use. I think this flow should be more explicit. Instead, ask first which provider you are using for creating the Toolkit group.
Co-authored-by: Anders Albert <[email protected]>
Co-authored-by: Anders Albert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t group
Description
Prefix the PR title with the Jira issue number on the form
[CDF-12345].Please describe the change you have made.
Checklist