fix(react-components): cad & point cloud models getting added multiple time due to incorrect transforms #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transforms is inccorect and also added important css properties for SlicerButton
Comment on lines
+124
to
+126
| overflow: hidden !important; | ||
| display: flex !important; | ||
| flex-direction: column !important; |
There was a problem hiding this comment.
Are these CSS changes needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Jira ticket 📘
https://cognitedata.atlassian.net/browse/BND3D-4996
Description 📝
In
Searchapp, when switching between list view to 3D, all Cad and point-cloud model was added each time. The issue was related to check inisSameModelwheretransformvalue fromviewer.modelpassed was incorrect.How has this been tested? 🔍
In
SearchappTest instructions ℹ️
Use
yalclinkChecklist ☑️