Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make update non-optional #767

Open
wants to merge 1 commit into
base: v3-dev
Choose a base branch
from
Open

Make update non-optional #767

wants to merge 1 commit into from

Conversation

einarmo
Copy link
Collaborator

@einarmo einarmo commented Jan 22, 2025

When we added support for "updating" metadata in CDF, it was done in a very flexible way.

Now that we write to DM more, it really makes a lot less sense, since depending on where you write there is no way to not update. We had some absolutely insane code to enable "updates" to Raw that can also be removed (no other extractors do anything like that).

In general, making updates non-optional greatly simplifies the extractor, and is almost certainly what pretty much every user wants.

Also identifies and fixes a bug related to the Source of arrays, this was never caught due to a hole in a test.

Also identifies and fixes a bug related to the `Source` of arrays, this
was never caught due to a hole in a test.
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 87.75510% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (v3-dev@f5fac9b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Extractor/Nodes/UAVariable.cs 58.33% 3 Missing and 2 partials ⚠️
Extractor/Nodes/UAVariableType.cs 50.00% 1 Missing and 1 partial ⚠️
Extractor/Pushers/PusherUtils.cs 93.75% 0 Missing and 2 partials ⚠️
Extractor/Nodes/BaseUANode.cs 93.33% 0 Missing and 1 partial ⚠️
Extractor/Nodes/UAObject.cs 66.66% 0 Missing and 1 partial ⚠️
Extractor/Pushers/Writers/CDFWriter.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             v3-dev     #767   +/-   ##
=========================================
  Coverage          ?   80.09%           
=========================================
  Files             ?      125           
  Lines             ?    16380           
  Branches          ?     2396           
=========================================
  Hits              ?    13119           
  Misses            ?     2537           
  Partials          ?      724           
Files with missing lines Coverage Δ
Extractor/Config/ExtractionConfig.cs 85.52% <ø> (ø)
Extractor/NodeSources/NodeHierarchyBuilder.cs 88.23% <100.00%> (ø)
Extractor/NodeSources/UANodeSource.cs 88.80% <ø> (ø)
Extractor/Pushers/CDFPusher.cs 81.44% <ø> (ø)
Extractor/Pushers/IPusher.cs 40.00% <ø> (ø)
Extractor/Pushers/Writers/BaseTimeseriesWriter.cs 87.87% <100.00%> (ø)
Extractor/Pushers/Writers/CleanWriter.cs 89.14% <100.00%> (ø)
Extractor/Pushers/Writers/IdmWriter.cs 32.77% <ø> (ø)
...tractor/Pushers/Writers/MinimalTimeseriesWriter.cs 90.90% <ø> (ø)
Extractor/Pushers/Writers/RawWriter.cs 93.93% <100.00%> (ø)
... and 10 more

@einarmo einarmo marked this pull request as ready for review January 22, 2025 09:51
@einarmo einarmo requested a review from a team as a code owner January 22, 2025 09:51
@einarmo einarmo changed the title Make update enabled by default Make update non-optional Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant