Update base.py #30
Merged
Update base.py #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update name of keyword argument for the call to self.client.raw.tables.create() from 'table' to 'name', which is corresponding to cognite-sdk versions ^6.0.0.
- switch to `extra="forbid"` - which avoids unnoticed misspelled properties in configurations
- like Dict, Set and Tuple
|
depandabot: |
- expected it to be visble as "Owner" column in extpipe listing - but it isn't, maybe a Fusion bug?
- changing the processing - which wasn't working when `naming-pattern` where used - using ExtractionPipelineList and `as_external_ids()` now
|
@janne123456789 I made several fixes now and tested
But with naming-pattern config only (there were more bugs than the raw-table parameter) Someone can test the changes please with your config? Then we can release it as v3.0.0-beta2 |
spex66
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update name of keyword argument for the call to self.client.raw.tables.create() from 'table' to 'name', which is corresponding to cognite-sdk versions ^6.0.0.