CDF-20260: allow customizing shouldRetry in RetryingBackend #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Predicate takes `request` and `response code` and it can
be used in consuming projects by tagging request with extra settings
if needed and applying custom policy. Default policy is also exposed
for reuse.
There's already `GenericClient.RESOURCE_TYPE_TAG` applied by default on
sdk side, so customization by resource type + response code should be
fairly easy to implement.
Not giving it full response (and response headers) for now because
in current setup response can be shadowed by exceptions that don't
keep track of full response context. Later on if the need for response
header-based logic arises we could extend this part in some way.
TBD: it may make sense that customization for resource + code
is put in the sdk default policy if that will be a fairly certain rule.
But first let's open up for customizations
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 73.95% 73.97% +0.01%
==========================================
Files 95 95
Lines 2880 2882 +2
Branches 33 36 +3
==========================================
+ Hits 2130 2132 +2
Misses 750 750
|
dmivankov
changed the title
amorken
approved these changes
Nov 14, 2023
| val maybeRetry: (Option[Int], Throwable) => F[Response[T]] = | ||
| (code: Option[Int], exception: Throwable) => | ||
| if (retriesRemaining > 0 && code.forall(shouldRetry)) { | ||
| val maybeRetry: (Option[StatusCode], Throwable) => F[Response[T]] = |
There was a problem hiding this comment.
💯 proper types are key to making lambda function signatures readable.
|
Uh I didn't realize my +1 would cause an automerge 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Predicate takes
requestandresponse codeand it canbe used in consuming projects by tagging request with extra settings
if needed and applying custom policy. Default policy is also exposed
for reuse.
There's already
GenericClient.RESOURCE_TYPE_TAGapplied by default onsdk side, so customization by resource type + response code should be
fairly easy to implement.
Not giving it full response (and response headers) for now because
in current setup response can be shadowed by exceptions that don't
keep track of full response context. Later on if the need for response
header-based logic arises we could extend this part in some way.
TBD: it may make sense that customization for resource + code
is put in the sdk default policy if that will be a fairly certain rule.
But first let's open up for customizations
Relates to #706
Needed for #709
CDF-20260