Fix data modeling data type Enum dumping #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2091 +/- ##
=======================================
Coverage 90.67% 90.68%
=======================================
Files 149 149
Lines 22881 22880 -1
=======================================
Hits 20748 20748
+ Misses 2133 2132 -1
|
haakonvt
force-pushed
the
fix-enum-dumping
branch
from
0765c9e to
c7ec016
Compare
doctrino
approved these changes
Jan 15, 2025
Comment on lines
+51
to
+52
| res = self._post(self._RESOURCE_PATH + "/summarize", json={"items": ident.as_dicts()}) | ||
| return Summary._load(res.json()["items"][0]) |
| @@ -276,8 +276,8 @@ def dump(self, camel_case: bool = True) -> dict[str, str | dict]: | |||
| output["immutable"] = self.immutable | |||
| for key in ["nullable", "auto_increment", "name", "default_value", "description"]: | |||
| if (value := getattr(self, key)) is not None: | |||
| output[key] = value | |||
| return convert_all_keys_to_camel_case_recursive(output) if camel_case else output | |||
There was a problem hiding this comment.
This is a dangerous function. Should we have a task to remove it? Or do it have any good use cases?
There was a problem hiding this comment.
Agreed, I had the same thought!
Comment on lines
+140
to
+143
| def test_ai(self): | ||
| run_docstring_tests(ai) | ||
| run_docstring_tests(ai.tools) | ||
| run_docstring_tests(ai.tools.documents) |
There was a problem hiding this comment.
Have they forgotten to do it?
There was a problem hiding this comment.
They did, and I missed it in review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cognitedata.atlassian.net/browse/DM-2478
Raised on slack: https://cognitedata.slack.com/archives/C031G8Y19HP/p1736859754500529