fix(ProfilePage): should see other users' profile page #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
approved these changes
Dec 22, 2024
This was referenced Jan 10, 2025
|
We found that the comments tab under user profile page is broken, not sure if it is related: #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explaination
I found that latestSlug returns null when the user hasn't set their slug yet. Therefore, I changed
latestSlug === undefinedto!latestSlug && latestSlug !== ''Additionally, if the user resets their slug to an empty string, it will fail the condition. To address this, I changed the userId to ensure redirection leads to the user's page instead of "my" page.
preview