Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix #242 #243

Closed
wants to merge 1 commit into from
Closed

Conversation

fishcharlie
Copy link

This looks to solve issue #242. Not sure if breaks other code or a solid long term solution but this solution worked for me personally.

@codykrieger
Copy link
Owner

Unfortunately this isn't a proper fix. Merely checking to see if the integrated GPU is active could mean you're on Dynamic Switching as well—Integrated Only means you're more or less locked to the integrated GPU.

Thanks, though!

@fishcharlie
Copy link
Author

Maybe I'm going crazy but that's what the dynamic bool is checking for. If dynamic is true it sets on state to dynamicSwitching. If dynamic is false then it checks to see if it's using the integrated or dedicated by calling [GSMux isUsingIntegratedGPU].

So it should still be checking dynamic vs integrated correct?

@fishcharlie
Copy link
Author

fishcharlie commented Jun 24, 2016

@codykrieger Am I wrong with that or?

@codykrieger
Copy link
Owner

Yeah. Integrated Only means more than just “is Dynamic Switching off && is the integrated GPU active.” This change doesn't preserve the meaning of Integrated Only.

#242 might be the latest incarnation of #103; perhaps it's just worse on macOS Sierra than it was before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants