-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Chronos V4 #673
Update to Chronos V4 #673
Conversation
d491a82
to
d8ee340
Compare
OK, to be able to wrap this up, we need the following to happen:
Of course
wouldn't hurt either, but that's not a blocker. 🙂 |
…ion args into coverage
…ts without too much hassle
* add special repo_version version to the Nim compiler which picks up what's in the repo
756b258
to
f92d069
Compare
…ink/move semantics
Where are we using these two in codex that is preventing us from getting a working solution for chronos v4? |
These are compiler bugs which affect |
Heads up Chronos v4.0.1 was released that removes all sink params https://forum.nim-lang.org/t/10914#73721
|
Awesome, this unblocks our migration path. The unfortunate thing is that this has been bumped to low prio as it's too late for it to make it into the testnet. |
We should update this and plan on integrating it ASAP. |
I'm closing this PR as we're going the v3 compat route (#814), which buys us some time to kick the can on debugging buggy deps down the road while still making progress on the v4 migration. |
This PR contains the changes required to have Codex running on Chronos V4.