Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove old fixme #1060

Merged
merged 2 commits into from
Jan 8, 2025
Merged

chore: remove old fixme #1060

merged 2 commits into from
Jan 8, 2025

Conversation

2-towns
Copy link
Contributor

@2-towns 2-towns commented Jan 7, 2025

This PR removes the FIXME that is no longer needed.

Copy link
Member

@gmega gmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gmega
Copy link
Member

gmega commented Jan 7, 2025

Uh-oh your CI is failing @2-towns

@2-towns
Copy link
Contributor Author

2-towns commented Jan 7, 2025

Uh-oh your CI is failing @2-towns

Yes, it was an indentation issue. Should be fixed by the last commit.

@2-towns 2-towns marked this pull request as ready for review January 7, 2025 19:16
@2-towns 2-towns added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 145aa5d Jan 8, 2025
17 checks passed
@2-towns 2-towns deleted the chore/remove-old-fixme branch January 8, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants