chore: update x/net to v0.32 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spikecurtis
reviewed
Dec 18, 2024
go.mod
Outdated
| @@ -75,16 +75,16 @@ require ( | |||
| go.uber.org/zap v1.24.0 | |||
| go4.org/mem v0.0.0-20220726221520-4f986261bf13 | |||
| go4.org/netipx v0.0.0-20230728180743-ad4cb58a6516 | |||
| golang.org/x/crypto v0.18.0 | |||
| golang.org/x/crypto v0.30.0 | |||
There was a problem hiding this comment.
I think there is a CVE in 0.30.0 --- can we bump to 0.31.0?
| "ICMPv4", | ||
| "GlobalV4", | ||
| "GlobalV6", | ||
| "CaptivePortal", |
There was a problem hiding this comment.
If you run go generate ./..., you get this test fails:
tailscale/tailcfg/tailcfg_test.go
Line 559 in d8574de
The change is only in a test, that validates the Clone() method is missing some fields. These fields were omitted in the test that we added here: #56
I was just getting a test to pass that was failing locally.
spikecurtis
approved these changes
Dec 18, 2024
Emyrk
added a commit
to coder/coder
that referenced
this pull request
Dec 20, 2024
To bring in coder/tailscale#66 Closes #15616
Emyrk
added a commit
to coder/coder
that referenced
this pull request
Jan 2, 2025
To bring in coder/tailscale#66 Closes #15616 (cherry picked from commit 2bba3d7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tailscale fix: tailscale#14297
Golang Issue: golang/go#70528
Commit in x/net that fixes it: golang/net@e9cd716
Coder issue: coder/coder#15616