Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch images to Ubuntu noble 24.04 #277

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Switch images to Ubuntu noble 24.04 #277

merged 2 commits into from
Sep 19, 2024

Conversation

matifali
Copy link
Member

  • Correct a typo in README.md
  • Update Docker sources to use 'noble'
  • Change base image from Ubuntu 22.04 to 'noble' 24.04

@matifali matifali self-assigned this Sep 19, 2024
@matifali matifali requested a review from johnstcn September 19, 2024 12:12
matifali
matifali commented Sep 19, 2024
View reviewed changes
Copy link
Member Author

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ubuntu noble images already contain a user ubuntu with uid 1000. What should we do? We can either reuse the ubuntu user or use a different uid for coder user.

@johnstcn
Copy link
Member

Need to fix uid of Coder user

@johnstcn
Copy link
Member

Ubuntu noble images already contain a user ubuntu with uid 1000. What should we do? We can either reuse the ubuntu user or use a different uid for coder user.

If the previous image version was fine with ubuntu=1000 and coder=1001 then let's keep it that way.

@matifali
Switch base Ubuntu image to 'noble' version
120b29d 
- Correct a typo in README.md
- Update Docker sources to use 'noble'
- Change base image from Ubuntu 22.04 to 'noble'

Adjust UID for coder user in Dockerfiles

Remove `ubuntu` user from Dockerfiles

Adjust UID for coder user in Dockerfiles

Use userdel to remove ubuntu user

Use userdel to remove ubuntu user
@matifali matifali changed the title Switch base Ubuntu image to 'noble' version Switch images to Ubuntu noble 24.04 Sep 19, 2024
@matifali matifali merged commit f50a923 into main Sep 19, 2024
4 checks passed
@matifali matifali deleted the noble branch September 19, 2024 14:23
matifali added a commit that referenced this pull request Sep 20, 2024
@matifali
Revert "Switch images to Ubuntu noble 24.04 (#277)"
4d1986a 
This reverts commit f50a923.
This was referenced Sep 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @johnstcn