Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump node to v20 #246

Merged
merged 2 commits into from
Jan 16, 2024
Merged

chore: bump node to v20 #246

merged 2 commits into from
Jan 16, 2024

Conversation

matifali
Copy link
Member

No description provided.

@matifali matifali requested a review from johnstcn January 16, 2024 13:09
johnstcn
johnstcn approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this but we could probably remove the NodeJS dependency from this repo entirely if we wanted to.

@matifali
Copy link
Member Author

matifali commented Jan 16, 2024 •
edited
Loading

@johnstcn yes. Thoughts on using bun? :D This just makes it easy to run format lint checks :) Creating #248 to follow up on this later.

@matifali matifali marked this pull request as ready for review January 16, 2024 13:18
@matifali matifali merged commit 99cd65f into main Jan 16, 2024
4 checks passed
@matifali matifali deleted the node-20 branch January 16, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @johnstcn