Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimjong95
reviewed
Nov 13, 2024
| router.patch('/:id/comment/:commentId', service.updateArticleComment); // 자유게시글 댓글 수정 | ||
| router.delete('/:id/comment/:commentId', service.deleteArticleComment); // 자유게시글 댓글 삭제 | ||
|
|
||
| export default router; |
There was a problem hiding this comment.
게시글과 댓글을 서로다른 컨트롤러로 분리해주셔도 좋을것 같습니다.
| const { id } = req.params; // 댓글 ID | ||
| const { content } = req.body; | ||
|
|
||
| const comment = await prisma.articleComment.update({ |
There was a problem hiding this comment.
수정이나 삭제를할때 id가 유효하지않으면 에러가 발생될 수도 있습니다.
이 케이스를 확인해보시면 좋을것 같아요.
현재는 asyncHandler에 구성된 try/catch로 처리가 되긴 할것 같습니다.
| limit = 10, | ||
| orderBy = 'recent', | ||
| keyword = '', | ||
| } = req.query as GetArticleListReqQueryProps; |
There was a problem hiding this comment.
query의 타입을 as를 통해 캐스팅해주셨습니다. 이렇게도 사용할 수 있지만 타입단언은 조금 위험할 수도 있습니다.
asyncHandler에 제네릭타입을 통해서 처리할 수도 있을것 같아요.
| type GetArticleListReqQueryProps = { | ||
| offset?: string; | ||
| limit?: string; | ||
| orderBy?: string; |
There was a problem hiding this comment.
orderBy와 같은값을 string이 아닌 Enum타입등으로 설정하는게 좋을것 같습니다.
kimjong95
approved these changes
Nov 13, 2024
| marketArticle MarketArticle @relation(fields: [articleId], references: [id], onDelete: Cascade) | ||
| articleId String | ||
| } | ||
|
|
There was a problem hiding this comment.
모델을 잘 구성해주신것 같아요. 테스트하실때 필요한 시딩이 필요할 수도 있을것 같아요
|
|
||
| const article = await prisma.article.update({ | ||
| where: { id }, | ||
| data, |
There was a problem hiding this comment.
필요한 값만 수정이 되도록 설정해주신것 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
중고마켓
공통
자유게시판
댓글
주요 변경사항
스크린샷
멘토에게