Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tile): do not default to SVGImage to true otherwise it doesn't work with standard svg #327

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

carolineBda
Copy link
Contributor

@carolineBda carolineBda commented Oct 15, 2024

⚠️ This would be a breaking change as the option imageSvg will not default to true anymore.

The reason for that change is that, as it stands, the Tile component is not usable with standard SVG or other image format unless the property imageSvg={false} is set

Copy link
Collaborator

@garronej garronej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks!

src/Tile.tsx Outdated Show resolved Hide resolved
Co-authored-by: Joseph Garrone <[email protected]>
Signed-off-by: Caroline <[email protected]>
@carolineBda carolineBda requested a review from garronej December 3, 2024 10:02
@ddecrulle ddecrulle merged commit 19cbd65 into codegouvfr:main Dec 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants