feat: lazy load card images #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 tasks
|
@garronej @ddecrulle Vous avez des avis sur ce qu'il manque pour intégrer ce changement ? |
|
Hello, personnellement je préfèrerais que ce soit paramétrable plutôt que le comportement par défaut. Je pense que le "layout shift" dépend de la taille de l'image ce que seul l'utilisateur de la librairie peut contrôler. Par exemple ajouter la props : |
|
La suite de cette PR ici 👉 #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #284
Ajoute loading="lazy" par défaut sur toutes les images des Card.
Je n'ai pas constaté de layout shift avec cette option (enfin je crois pas, j'ai testé avec réseau émulé 3G lent).
Par contre j'ai fait le strict minimum pour l'instant, cad aucune mention dans la doc. Je pourrai compléter demain.