-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: handle NoConfirugedAppsAvailable error #758
Conversation
These changes handle `NoConfiguredAppsAvailable`. There is no way of recovering from that - similar to `RepositoryWithoutValidBotError` - but we can fail in a clean way instead of just dying with an exception. closes [WORKER-P24](https://codecov.sentry.io/issues/5763549073/)
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36286 36310 +24
=======================================
+ Hits 35570 35594 +24
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36286 36310 +24
=======================================
+ Hits 35570 35594 +24
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36286 36310 +24
=======================================
+ Hits 35570 35594 +24
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 98.02% 98.02%
=======================================
Files 437 437
Lines 36286 36310 +24
=======================================
+ Hits 35570 35594 +24
Misses 716 716
Flags with carried forward coverage won't be shown. Click here to find out more.
|
These changes handle
NoConfiguredAppsAvailable
. There is no way of recoveringfrom that - similar to
RepositoryWithoutValidBotError
- but we can fail in a clean wayinstead of just dying with an exception.
closes WORKER-P24