Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle NoConfirugedAppsAvailable error #758

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

giovanni-guidini
Copy link
Contributor

These changes handle NoConfiguredAppsAvailable. There is no way of recovering
from that - similar to RepositoryWithoutValidBotError - but we can fail in a clean way
instead of just dying with an exception.

closes WORKER-P24

These changes handle `NoConfiguredAppsAvailable`. There is no way of recovering
from that - similar to `RepositoryWithoutValidBotError` - but we can fail in a clean way
instead of just dying with an exception.

closes [WORKER-P24](https://codecov.sentry.io/issues/5763549073/)
@giovanni-guidini giovanni-guidini requested a review from a team October 3, 2024 14:48
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (18aed4e) to head (6427658).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36286    36310   +24     
=======================================
+ Hits        35570    35594   +24     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <ø> (ø)
Files with missing lines Coverage Δ
tasks/sync_pull.py 94.35% <100.00%> (+0.21%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (18aed4e) to head (6427658).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36286    36310   +24     
=======================================
+ Hits        35570    35594   +24     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <ø> (ø)
Files with missing lines Coverage Δ
tasks/sync_pull.py 94.35% <100.00%> (+0.21%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36286    36310   +24     
=======================================
+ Hits        35570    35594   +24     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <ø> (ø)
Files with missing lines Coverage Δ
tasks/sync_pull.py 94.35% <100.00%> (+0.21%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.02%. Comparing base (18aed4e) to head (6427658).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files         437      437           
  Lines       36286    36310   +24     
=======================================
+ Hits        35570    35594   +24     
  Misses        716      716           
Flag Coverage Δ
integration 98.02% <100.00%> (+<0.01%) ⬆️
unit 98.02% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.88% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.03% <ø> (ø)
Files Coverage Δ
tasks/sync_pull.py 94.35% <100.00%> (+0.21%) ⬆️
tasks/tests/unit/test_sync_pull.py 100.00% <100.00%> (ø)

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Oct 3, 2024
Merged via the queue into main with commit 97cacbc Oct 3, 2024
26 of 27 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/handle-noconfiguredapps branch October 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants