Simplifies get_installation_name a bit
#749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 98.08% 98.08% -0.01%
==========================================
Files 432 432
Lines 36292 36292
==========================================
- Hits 35598 35596 -2
- Misses 694 696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 98.08% 98.08% -0.01%
==========================================
Files 432 432
Lines 36292 36292
==========================================
- Hits 35598 35596 -2
- Misses 694 696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 98.08% 98.08% -0.01%
==========================================
Files 432 432
Lines 36292 36292
==========================================
- Hits 35598 35596 -2
- Misses 694 696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #749 +/- ##
==========================================
- Coverage 98.08% 98.08% -0.01%
==========================================
Files 432 432
Lines 36292 36292
==========================================
- Hits 35598 35596 -2
- Misses 694 696 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Sep 30, 2024
This concept is only relevant for github, so move an appropriate check inside. Also removes the superfluous `dbsession` parameter, and removes the caching which is quite the overkill for this very simple query.
Swatinem
force-pushed
the
swatinem/installation
branch
from
bea4f17 to
9f5f7b9
Compare
giovanni-guidini
approved these changes
Sep 30, 2024
Swatinem
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concept is only relevant for github, so move an appropriate check inside.
Also removes the superfluous
dbsessionparameter, and removes the caching which is quite the overkill for this very simple query: