feat: add backfill one off scripts #734

joseph-sentry · 2024-09-23T17:58:09Z

these are one off python scripts to be run directly that will modify the database

the first backfills the daily test rollups starting on a given day, and ending on a given date, starting for a given repo (it will backfill in repo id order)

the second backfills the TestFlagBridge objects for all repos with the option to focus on a given repo, specified by repoid

codecov-notifications · 2024-09-23T18:04:59Z

Codecov Report

Attention: Patch coverage is 89.09953% with 23 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
one_off_scripts/backfill_daily_test_rollups.py	87.12%	13 Missing ⚠️
one_off_script.py	0.00%	9 Missing ⚠️
one_off_scripts/backfill_test_flag_bridges.py	96.29%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   98.09%   98.02%   -0.07%     
==========================================
  Files         432      438       +6     
  Lines       36325    36283      -42     
==========================================
- Hits        35632    35566      -66     
- Misses        693      717      +24

Flag	Coverage Δ
integration	`98.02% <89.09%> (-0.07%)`	⬇️
unit	`98.02% <89.09%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.87% <83.68%> (-0.16%)`	⬇️
OutsideTasks	`98.03% <89.09%> (-0.10%)`	⬇️

Files with missing lines	Coverage Δ
one_off_scripts/__init__.py	`100.00% <100.00%> (ø)`
..._scripts/tests/test_backfill_daily_test_rollups.py	`100.00% <100.00%> (ø)`
...f_scripts/tests/test_backfill_test_flag_bridges.py	`100.00% <100.00%> (ø)`
one_off_scripts/backfill_test_flag_bridges.py	`96.29% <96.29%> (ø)`
one_off_script.py	`0.00% <0.00%> (ø)`
one_off_scripts/backfill_daily_test_rollups.py	`87.12% <87.12%> (ø)`

... and 21 files with indirect coverage changes

codecov-qa · 2024-09-23T18:05:06Z

Codecov Report

Attention: Patch coverage is 89.09953% with 23 lines in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (85f3174) to head (e00f450).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
one_off_scripts/backfill_daily_test_rollups.py	87.12%	13 Missing ⚠️
one_off_script.py	0.00%	9 Missing ⚠️
one_off_scripts/backfill_test_flag_bridges.py	96.29%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   98.09%   98.02%   -0.07%     
==========================================
  Files         432      438       +6     
  Lines       36325    36283      -42     
==========================================
- Hits        35632    35566      -66     
- Misses        693      717      +24

Flag	Coverage Δ
integration	`98.02% <89.09%> (-0.07%)`	⬇️
unit	`98.02% <89.09%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.87% <83.68%> (-0.16%)`	⬇️
OutsideTasks	`98.03% <89.09%> (-0.10%)`	⬇️

Files with missing lines	Coverage Δ
one_off_scripts/__init__.py	`100.00% <100.00%> (ø)`
..._scripts/tests/test_backfill_daily_test_rollups.py	`100.00% <100.00%> (ø)`
...f_scripts/tests/test_backfill_test_flag_bridges.py	`100.00% <100.00%> (ø)`
one_off_scripts/backfill_test_flag_bridges.py	`96.29% <96.29%> (ø)`
one_off_script.py	`0.00% <0.00%> (ø)`
one_off_scripts/backfill_daily_test_rollups.py	`87.12% <87.12%> (ø)`

... and 21 files with indirect coverage changes

codecov-public-qa · 2024-09-23T18:05:22Z

Codecov Report

Attention: Patch coverage is 89.09953% with 23 lines in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (85f3174) to head (e00f450).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   98.09%   98.02%   -0.07%     
==========================================
  Files         432      438       +6     
  Lines       36325    36283      -42     
==========================================
- Hits        35632    35566      -66     
- Misses        693      717      +24

Flag	Coverage Δ
integration	`98.02% <89.09%> (-0.07%)`	⬇️
unit	`98.02% <89.09%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.87% <83.68%> (-0.16%)`	⬇️
OutsideTasks	`98.03% <89.09%> (-0.10%)`	⬇️

Files	Coverage Δ
one_off_scripts/__init__.py	`100.00% <100.00%> (ø)`
..._scripts/tests/test_backfill_daily_test_rollups.py	`100.00% <100.00%> (ø)`
...f_scripts/tests/test_backfill_test_flag_bridges.py	`100.00% <100.00%> (ø)`
one_off_scripts/backfill_test_flag_bridges.py	`96.29% <96.29%> (ø)`
one_off_script.py	`0.00% <0.00%> (ø)`
one_off_scripts/backfill_daily_test_rollups.py	`87.12% <87.12%> (ø)`

... and 21 files with indirect coverage changes

codecov · 2024-09-23T18:05:27Z

Codecov Report

Attention: Patch coverage is 89.09953% with 23 lines in your changes missing coverage. Please review.

Project coverage is 98.02%. Comparing base (85f3174) to head (e00f450).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
one_off_scripts/backfill_daily_test_rollups.py	87.12%	13 Missing ⚠️
one_off_script.py	0.00%	9 Missing ⚠️
one_off_scripts/backfill_test_flag_bridges.py	96.29%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #734      +/-   ##
==========================================
- Coverage   98.09%   98.02%   -0.07%     
==========================================
  Files         432      438       +6     
  Lines       36325    36283      -42     
==========================================
- Hits        35632    35566      -66     
- Misses        693      717      +24

Flag	Coverage Δ
integration	`98.02% <89.09%> (-0.07%)`	⬇️
unit	`98.02% <89.09%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	`95.87% <83.68%> (-0.16%)`	⬇️
OutsideTasks	`98.03% <89.09%> (-0.10%)`	⬇️

Files with missing lines	Coverage Δ
one_off_scripts/__init__.py	`100.00% <100.00%> (ø)`
..._scripts/tests/test_backfill_daily_test_rollups.py	`100.00% <100.00%> (ø)`
...f_scripts/tests/test_backfill_test_flag_bridges.py	`100.00% <100.00%> (ø)`
one_off_scripts/backfill_test_flag_bridges.py	`96.29% <96.29%> (ø)`
one_off_script.py	`0.00% <0.00%> (ø)`
one_off_scripts/backfill_daily_test_rollups.py	`87.12% <87.12%> (ø)`

... and 21 files with indirect coverage changes

Swatinem · 2024-09-26T11:52:22Z

one_off_scripts/__init__.py

+os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_scaffold.settings")
+django.setup()


any reason this is duplicated from the main script? does this actually run twice when you import one of the child scripts?

These scripts are meant to be run separately from the actual application running on a pod so we'd invoke it directly using python one_off_script.py and that means we have to setup django separately

one_off_scripts/backfill_daily_test_rollups.py

one_off_scripts/backfill_test_flag_bridges.py

Swatinem · 2024-09-27T07:57:24Z

one_off_scripts/backfill_test_flag_bridges.py

+            try:
+                first_test_instance = TestInstance.objects.filter(
+                    test_id=test.id
+                ).select_related("upload")[0]
+            except IndexError:
+                continue


The first method might be an alternative here, it even mentions it being the same pattern in its doc example.

these are one off python scripts to be run directly that will modify the database the first backfills the daily test rollups starting on a given day, and ending on a given date, starting for a given repo (it will backfill in repo id order) the second backfills the TestFlagBridge objects for all repos with the option to focus on a given repo, specified by repoid

Swatinem · 2024-09-30T08:06:34Z

one_off_scripts/backfill_test_flag_bridges.py

+                first_test_instance = (
+                    TestInstance.objects.filter(test_id=test.id)
+                    .select_related("upload")
+                    .first()


my comment might have been confusing. I believe first returns None if the element does not exist instead of the IndexError.

github-actions · 2024-10-01T17:43:31Z

This PR includes changes to shared. Please review them here: codecov/shared@106b0ae...36791fe

…st flag bridges

nora-codecov · 2024-10-01T18:15:08Z

one_off_scripts/backfill_daily_test_rollups.py

+    ).order_by("repoid")
+
+    if start_repoid is not None:
+        test_analytics_repos = test_analytics_repos.filter(repoid__gte=start_repoid)


Swatinem reviewed Sep 26, 2024

View reviewed changes

Swatinem reviewed Sep 27, 2024

View reviewed changes

joseph-sentry requested a review from Swatinem September 27, 2024 15:41

joseph-sentry added 4 commits September 27, 2024 14:53

fix: address feedback and add a test for backfill daily test rollups

4730f1e

test: write test for backfill_test_flag_bridges

8f02930

fix: use first instead of an index access

b584a44

Swatinem reviewed Sep 30, 2024

View reviewed changes

Adal3n3 mentioned this pull request Oct 1, 2024

[TA] UI Support Work codecov/engineering-team#2528

Closed

update shared

66a56d1

joseph-sentry force-pushed the joseph/backfill-rollups branch from e795f6d to 66a56d1 Compare October 1, 2024 17:43

joseph-sentry added 2 commits October 1, 2024 13:47

fix: address feedback

4ca001c

test: cover case where test doesn't have any instances in backfill te…

e00f450

…st flag bridges

joseph-sentry requested a review from a team October 1, 2024 17:57

nora-codecov approved these changes Oct 1, 2024

View reviewed changes

joseph-sentry added this pull request to the merge queue Oct 1, 2024

Merged via the queue into main with commit d4d1fa4 Oct 1, 2024
15 of 27 checks passed

joseph-sentry deleted the joseph/backfill-rollups branch October 1, 2024 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add backfill one off scripts #734

feat: add backfill one off scripts #734

joseph-sentry commented Sep 23, 2024

codecov-notifications bot commented Sep 23, 2024 •

edited

Loading

codecov-qa bot commented Sep 23, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading

Swatinem Sep 26, 2024

joseph-sentry Sep 26, 2024

Swatinem Sep 27, 2024

Swatinem Sep 30, 2024

github-actions bot commented Oct 1, 2024

nora-codecov Oct 1, 2024

		os.environ.setdefault("DJANGO_SETTINGS_MODULE", "django_scaffold.settings")
		django.setup()

feat: add backfill one off scripts #734

feat: add backfill one off scripts #734

Conversation

joseph-sentry commented Sep 23, 2024

codecov-notifications bot commented Sep 23, 2024 • edited Loading

Codecov Report

codecov-qa bot commented Sep 23, 2024 • edited Loading

Codecov Report

codecov-public-qa bot commented Sep 23, 2024 • edited Loading

Codecov Report

codecov bot commented Sep 23, 2024 • edited Loading

Codecov Report

Swatinem Sep 26, 2024

Choose a reason for hiding this comment

joseph-sentry Sep 26, 2024

Choose a reason for hiding this comment

Swatinem Sep 27, 2024

Choose a reason for hiding this comment

Swatinem Sep 30, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 1, 2024

nora-codecov Oct 1, 2024

Choose a reason for hiding this comment

codecov-notifications bot commented Sep 23, 2024 •

edited

Loading

codecov-qa bot commented Sep 23, 2024 •

edited

Loading

codecov-public-qa bot commented Sep 23, 2024 •

edited

Loading

codecov bot commented Sep 23, 2024 •

edited

Loading