Coveralls parser now accepts json-encoded coverage
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like for some reason, the `coverage` can also be a string with a json-encoded list. This change handles that case.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36764 36775 +11
=======================================
+ Hits 36055 36066 +11
Misses 709 709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36764 36775 +11
=======================================
+ Hits 36055 36066 +11
Misses 709 709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 475 475
Lines 38119 38130 +11
=======================================
+ Hits 37402 37413 +11
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #724 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36764 36775 +11
=======================================
+ Hits 36055 36066 +11
Misses 709 709
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like for some reason, the
coveragecan also be a string with a json-encoded list. This change handles that case.Fixes WORKER-PA5, fixes https://github.com/codecov/internal-issues/issues/797