Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various foreign key column definitions #721

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

Swatinem
Copy link
Contributor

This primarily changes the types from Integer (i32) to BigInteger (i64), to align foreign keys with the column types they are pointing to.

At least for reports_uploadleveltotals.upload_id, the column in production is already an i64, and the column values exceed the value range of an i32.

This primarily changes the types from `Integer` (i32) to `BigInteger` (i64), to align foreign keys with the column types they are pointing to.

At least for `reports_uploadleveltotals.upload_id`, the column in production is already an i64, and the column values exceed the value range of an i32.
@Swatinem Swatinem requested review from michelletran-codecov and a team September 18, 2024 15:16
@Swatinem Swatinem self-assigned this Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (6ecd3ba) to head (6076197).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         475      475           
  Lines       38089    38089           
=======================================
  Hits        37374    37374           
  Misses        715      715           
Flag Coverage Δ
integration ?
latest-uploader-overall 98.07% <100.00%> (ø)
unit 98.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.08% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files with missing lines Coverage Δ
database/models/reports.py 99.50% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@codecov-qa
Copy link

codecov-qa bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (6ecd3ba) to head (6076197).
Report is 6 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36734    36734           
=======================================
  Hits        36027    36027           
  Misses        707      707           
Flag Coverage Δ
integration 98.07% <100.00%> (ø)
latest-uploader-overall 98.07% <100.00%> (ø)
unit 98.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files with missing lines Coverage Δ
database/models/reports.py 99.50% <100.00%> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36734    36734           
=======================================
  Hits        36027    36027           
  Misses        707      707           
Flag Coverage Δ
integration 98.07% <100.00%> (ø)
latest-uploader-overall ?
unit 98.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files Coverage Δ
database/models/reports.py 99.50% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (6ecd3ba) to head (6076197).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #721   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36734    36734           
=======================================
  Hits        36027    36027           
  Misses        707      707           
Flag Coverage Δ
integration 98.07% <100.00%> (ø)
latest-uploader-overall 98.07% <100.00%> (ø)
unit 98.07% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.97% <100.00%> (ø)
OutsideTasks 98.09% <100.00%> (ø)
Files Coverage Δ
database/models/reports.py 99.50% <100.00%> (ø)

@Swatinem Swatinem added this pull request to the merge queue Sep 19, 2024
@Swatinem Swatinem removed this pull request from the merge queue due to a manual request Sep 19, 2024
@Swatinem Swatinem added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 7def62c Sep 19, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/foreign-keys branch September 19, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants