-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various foreign key column definitions #721
Conversation
This primarily changes the types from `Integer` (i32) to `BigInteger` (i64), to align foreign keys with the column types they are pointing to. At least for `reports_uploadleveltotals.upload_id`, the column in production is already an i64, and the column values exceed the value range of an i32.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 475 475
Lines 38089 38089
=======================================
Hits 37374 37374
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36734 36734
=======================================
Hits 36027 36027
Misses 707 707
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36734 36734
=======================================
Hits 36027 36027
Misses 707 707
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #721 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 434 434
Lines 36734 36734
=======================================
Hits 36027 36027
Misses 707 707
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This primarily changes the types from
Integer
(i32) toBigInteger
(i64), to align foreign keys with the column types they are pointing to.At least for
reports_uploadleveltotals.upload_id
, the column in production is already an i64, and the column values exceed the value range of an i32.