-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WORKER-P8R #702
fix: WORKER-P8R #702
Conversation
For the `commit_status` context it's possible that the `pull` is `None` (which is not the case for `comment`). I forgot to include that check. This really shows that: (1) the builders pattern is not very good, because of code duplication, and (2) we need better tests But for now this only fixes issue worker-p8r
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36600 36610 +10
==========================================
+ Hits 35904 35913 +9
- Misses 696 697 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36600 36610 +10
==========================================
+ Hits 35904 35913 +9
- Misses 696 697 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 98.09% 98.09% -0.01%
==========================================
Files 434 434
Lines 36600 36610 +10
==========================================
+ Hits 35904 35913 +9
- Misses 696 697 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 98.14% 98.14% -0.01%
==========================================
Files 475 475
Lines 37955 37965 +10
==========================================
+ Hits 37250 37259 +9
- Misses 705 706 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes This change has been scanned for critical changes. Learn more |
For the
commit_status
context it's possible that thepull
isNone
(which is not the case forcomment
). I forgot to include that check.This really shows that:
(1) the builders pattern is not very good, because of code duplication, and
(2) we need better tests
But for now this only fixes issue worker-p8r