feat: upgrade message in BA commit status #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the bundle analysis - no longer in beta - to be similar to coverage in terms of seat count. After some code review I stumbled upon https://github.com/codecov/worker/blob/ab427f8311ee1d9306f692f531c67e3897786faf/services/notification/notifiers/status/base.py#L47 This was not yet ported to bundle analysis. So these changes do just that.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 434 434
Lines 36548 36600 +52
=======================================
+ Hits 35852 35904 +52
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 434 434
Lines 36548 36600 +52
=======================================
+ Hits 35852 35904 +52
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 98.09% 98.09%
=======================================
Files 434 434
Lines 36548 36600 +52
=======================================
+ Hits 35852 35904 +52
Misses 696 696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 475 475
Lines 37903 37955 +52
=======================================
+ Hits 37198 37250 +52
Misses 705 705
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Swatinem
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the bundle analysis - no longer in beta - to be similar to coverage
in terms of seat count.
After some code review I stumbled upon
worker/services/notification/notifiers/status/base.py
Line 47 in ab427f8
This was not yet ported to bundle analysis. So these changes do just that.