Revert "170 2 adjust event only to fire when due" #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 853534a.
michelletran-codecov
approved these changes
Sep 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 98.07% 98.07% -0.01%
==========================================
Files 434 434
Lines 36728 36721 -7
==========================================
- Hits 36022 36015 -7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 98.07% 98.07% -0.01%
==========================================
Files 434 434
Lines 36728 36721 -7
==========================================
- Hits 36022 36015 -7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 98.12% 98.12% -0.01%
==========================================
Files 474 474
Lines 38054 38047 -7
==========================================
- Hits 37340 37333 -7
Misses 714 714
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #678 +/- ##
==========================================
- Coverage 98.07% 98.07% -0.01%
==========================================
Files 434 434
Lines 36728 36721 -7
==========================================
- Hits 36022 36015 -7
Misses 706 706
Flags with carried forward coverage won't be shown. Click here to find out more.
|
adrian-codecov
deleted the
revert-664-170-2-adjust-event-only-to-fire-when-due
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #664