-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix flake model #662
fix flake model #662
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 437 437
Lines 36885 36892 +7
==========================================
+ Hits 36173 36179 +6
- Misses 712 713 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 437 437
Lines 36885 36892 +7
==========================================
+ Hits 36173 36179 +6
- Misses 712 713 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 98.06% 98.06% -0.01%
==========================================
Files 437 437
Lines 36885 36892 +7
==========================================
+ Hits 36173 36179 +6
- Misses 712 713 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 98.11% 98.11% -0.01%
==========================================
Files 476 476
Lines 38206 38213 +7
==========================================
+ Hits 37486 37492 +6
- Misses 720 721 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
the Flake model defined in shared uses the
BaseModel
which does not include theexternal_id
field.The
Flake
model defined in worker used theMixinBaseClass
that included that field, I made a newMixinBaseClassWithNoExternalID
so that there's an equivalent base class mixin for theBaseModel
in shared, and changed theFlake
to use that