Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake model #662

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix flake model #662

merged 1 commit into from
Aug 29, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Aug 29, 2024

the Flake model defined in shared uses the BaseModel which does not include the external_id field.

The Flake model defined in worker used the MixinBaseClass that included that field, I made a new MixinBaseClassWithNoExternalID so that there's an equivalent base class mixin for the BaseModel in shared, and changed the Flake to use that

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
database/base.py 85.71% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files         437      437              
  Lines       36885    36892       +7     
==========================================
+ Hits        36173    36179       +6     
- Misses        712      713       +1     
Flag Coverage Δ
integration 98.06% <88.88%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <88.88%> (-0.01%) ⬇️
unit 98.06% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <88.88%> (-0.01%) ⬇️
OutsideTasks 98.06% <88.88%> (-0.01%) ⬇️
Files Coverage Δ
database/models/reports.py 99.46% <100.00%> (ø)
database/base.py 96.15% <85.71%> (-3.85%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (894f2b3) to head (0588366).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/base.py 85.71% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files         437      437              
  Lines       36885    36892       +7     
==========================================
+ Hits        36173    36179       +6     
- Misses        712      713       +1     
Flag Coverage Δ
integration 98.06% <88.88%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <88.88%> (-0.01%) ⬇️
unit 98.06% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <88.88%> (-0.01%) ⬇️
OutsideTasks 98.06% <88.88%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 99.46% <100.00%> (ø)
database/base.py 96.15% <85.71%> (-3.85%) ⬇️

@joseph-sentry joseph-sentry added this pull request to the merge queue Aug 29, 2024
Copy link

codecov-public-qa bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (894f2b3) to head (0588366).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   98.06%   98.06%   -0.01%     
==========================================
  Files         437      437              
  Lines       36885    36892       +7     
==========================================
+ Hits        36173    36179       +6     
- Misses        712      713       +1     
Flag Coverage Δ
integration 98.06% <88.88%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <88.88%> (-0.01%) ⬇️
unit 98.06% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <88.88%> (-0.01%) ⬇️
OutsideTasks 98.06% <88.88%> (-0.01%) ⬇️
Files Coverage Δ
database/models/reports.py 99.46% <100.00%> (ø)
database/base.py 96.15% <85.71%> (-3.85%) ⬇️

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (894f2b3) to head (0588366).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/base.py 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #662      +/-   ##
==========================================
- Coverage   98.11%   98.11%   -0.01%     
==========================================
  Files         476      476              
  Lines       38206    38213       +7     
==========================================
+ Hits        37486    37492       +6     
- Misses        720      721       +1     
Flag Coverage Δ
integration 98.06% <88.88%> (-0.01%) ⬇️
latest-uploader-overall 98.06% <88.88%> (-0.01%) ⬇️
unit 98.06% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <88.88%> (-0.01%) ⬇️
OutsideTasks 98.06% <88.88%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
database/models/reports.py 99.46% <100.00%> (ø)
database/base.py 96.15% <85.71%> (-3.85%) ⬇️

This change has been scanned for critical changes. Learn more

Merged via the queue into main with commit 3cdf975 Aug 29, 2024
23 of 26 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-flake branch August 29, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants