Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sentry Events/Metrics for ParallelVerification #655

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Add Sentry Events/Metrics for ParallelVerification #655

merged 1 commit into from
Aug 29, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem requested a review from a team August 29, 2024 11:37
@Swatinem Swatinem self-assigned this Aug 29, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
tasks/parallel_verification.py 41.66% 7 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   98.05%   98.06%           
=======================================
  Files         437      437           
  Lines       36849    36806   -43     
=======================================
- Hits        36134    36095   -39     
+ Misses        715      711    -4
Flag Coverage Δ
integration 98.06% <41.66%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <41.66%> (+<0.01%) ⬆️
unit 98.06% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <41.66%> (+0.02%) ⬆️
OutsideTasks 98.06% <ø> (-0.01%) ⬇️
Files Coverage Δ
tasks/parallel_verification.py 78.78% <41.66%> (+5.25%) ⬆️

... and 5 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (aea8367) to head (5373039).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/parallel_verification.py 41.66% 7 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   98.05%   98.06%           
=======================================
  Files         437      437           
  Lines       36849    36806   -43     
=======================================
- Hits        36134    36095   -39     
+ Misses        715      711    -4
Flag Coverage Δ
integration 98.06% <41.66%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <41.66%> (+<0.01%) ⬆️
unit 98.06% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <41.66%> (+0.02%) ⬆️
OutsideTasks 98.06% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
tasks/parallel_verification.py 78.78% <41.66%> (+5.25%) ⬆️

... and 5 files with indirect coverage changes

@codecov Codecov
Copy link

codecov bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.11%. Comparing base (aea8367) to head (5373039).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
tasks/parallel_verification.py 41.66% 7 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   98.10%   98.11%   +0.01%     
==========================================
  Files         476      476              
  Lines       38170    38282     +112     
==========================================
+ Hits        37447    37562     +115     
+ Misses        723      720       -3
Flag Coverage Δ
integration 98.06% <41.66%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <41.66%> (+<0.01%) ⬆️
unit 98.06% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.04% <41.66%> (+0.02%) ⬆️
OutsideTasks 98.06% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
tasks/parallel_verification.py 78.78% <41.66%> (+5.25%) ⬆️

... and 5 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.ParallelVerification

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Aug 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 98.06%. Comparing base (aea8367) to head (5373039).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   98.05%   98.06%           
=======================================
  Files         437      437           
  Lines       36849    36806   -43     
=======================================
- Hits        36134    36095   -39     
+ Misses        715      711    -4
Flag Coverage Δ
integration 98.06% <41.66%> (+<0.01%) ⬆️
latest-uploader-overall 98.06% <41.66%> (+<0.01%) ⬆️
unit 98.06% <41.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.94% <41.66%> (+0.02%) ⬆️
OutsideTasks 98.06% <ø> (-0.01%) ⬇️
Files Coverage Δ
tasks/parallel_verification.py 78.78% <41.66%> (+5.25%) ⬆️

... and 5 files with indirect coverage changes

joseph-sentry
joseph-sentry approved these changes Aug 29, 2024
View reviewed changes
tasks/parallel_verification.py
if not top_level_totals_match:
scope.set_extra("parallel_totals", parallel_report.totals.astuple())
scope.set_extra("serial_totals", serial_report.totals.astuple())
sentry_sdk.capture_message(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this sort of thing show up on the Sentry UI? Would this be considered an error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows up in the issues list, but it is not considered an error.

@Swatinem Swatinem added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit cdf0f80 Aug 29, 2024
19 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/parallel-metrics branch August 29, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-sentry joseph-sentry joseph-sentry approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Worker] Metrics for parallel verification
2 participants
@Swatinem @joseph-sentry