-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logs to signals #649
Add logs to signals #649
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.01%
==========================================
Files 437 437
Lines 36727 36736 +9
==========================================
+ Hits 36034 36041 +7
- Misses 693 695 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.01%
==========================================
Files 437 437
Lines 36727 36736 +9
==========================================
+ Hits 36034 36041 +7
- Misses 693 695 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 98.15% 98.15% -0.01%
==========================================
Files 476 476
Lines 38048 38057 +9
==========================================
+ Hits 37347 37354 +7
- Misses 701 703 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #649 +/- ##
==========================================
- Coverage 98.11% 98.10% -0.01%
==========================================
Files 437 437
Lines 36727 36736 +9
==========================================
+ Hits 36034 36041 +7
- Misses 693 695 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Adding logs to signals to also see if worker captures all these signals in the first place. Also align the signature bw worker and shelter
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.