Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs to signals #649

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add logs to signals #649

merged 2 commits into from
Aug 28, 2024

Conversation

adrian-codecov
Copy link
Contributor

Adding logs to signals to also see if worker captures all these signals in the first place. Also align the signature bw worker and shelter

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
database/events.py 86.66% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   98.11%   98.10%   -0.01%     
==========================================
  Files         437      437              
  Lines       36727    36736       +9     
==========================================
+ Hits        36034    36041       +7     
- Misses        693      695       +2     
Flag Coverage Δ
integration 98.10% <86.66%> (-0.01%) ⬇️
latest-uploader-overall 98.10% <86.66%> (-0.01%) ⬇️
unit 98.10% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <86.66%> (-0.02%) ⬇️
OutsideTasks 98.08% <86.66%> (-0.01%) ⬇️
Files Coverage Δ
database/events.py 93.75% <86.66%> (-6.25%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (2faadcf) to head (9c8c75f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
database/events.py 86.66% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   98.11%   98.10%   -0.01%     
==========================================
  Files         437      437              
  Lines       36727    36736       +9     
==========================================
+ Hits        36034    36041       +7     
- Misses        693      695       +2     
Flag Coverage Δ
integration 98.10% <86.66%> (-0.01%) ⬇️
latest-uploader-overall 98.10% <86.66%> (-0.01%) ⬇️
unit 98.10% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <86.66%> (-0.02%) ⬇️
OutsideTasks 98.08% <86.66%> (-0.01%) ⬇️
Files Coverage Δ
database/events.py 93.75% <86.66%> (-6.25%) ⬇️

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.15%. Comparing base (2faadcf) to head (9c8c75f).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files Patch % Lines
database/events.py 86.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   98.15%   98.15%   -0.01%     
==========================================
  Files         476      476              
  Lines       38048    38057       +9     
==========================================
+ Hits        37347    37354       +7     
- Misses        701      703       +2     
Flag Coverage Δ
integration 98.10% <86.66%> (-0.01%) ⬇️
latest-uploader-overall 98.10% <86.66%> (-0.01%) ⬇️
unit 98.10% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.13% <86.66%> (-0.02%) ⬇️
OutsideTasks 98.08% <86.66%> (-0.01%) ⬇️
Files Coverage Δ
database/events.py 93.75% <86.66%> (-6.25%) ⬇️
Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.upload.PreProcessUpload
run/app.tasks.sync_repo_languages.SyncLanguages
run/app.tasks.sync_repos.SyncRepos

Copy link

codecov-public-qa bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 98.10%. Comparing base (2faadcf) to head (9c8c75f).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   98.11%   98.10%   -0.01%     
==========================================
  Files         437      437              
  Lines       36727    36736       +9     
==========================================
+ Hits        36034    36041       +7     
- Misses        693      695       +2     
Flag Coverage Δ
integration 98.10% <86.66%> (-0.01%) ⬇️
latest-uploader-overall 98.10% <86.66%> (-0.01%) ⬇️
unit 98.10% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <86.66%> (-0.02%) ⬇️
OutsideTasks 98.08% <86.66%> (-0.01%) ⬇️
Files Coverage Δ
database/events.py 93.75% <86.66%> (-6.25%) ⬇️

@adrian-codecov adrian-codecov added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 5c50d27 Aug 28, 2024
23 of 26 checks passed
@adrian-codecov adrian-codecov deleted the 524-shelter-add-logs-to-signals branch August 28, 2024 16:05
@adrian-codecov adrian-codecov restored the 524-shelter-add-logs-to-signals branch August 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants