Consider contents when choosing between v1/legacy ReportParser #630
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 438 438
Lines 36565 36572 +7
=======================================
+ Hits 35884 35892 +8
+ Misses 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 438 438
Lines 36565 36572 +7
=======================================
+ Hits 35884 35892 +8
+ Misses 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 98.13% 98.14%
=======================================
Files 438 438
Lines 36565 36572 +7
=======================================
+ Hits 35884 35892 +8
+ Misses 681 680 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
=======================================
Coverage 98.15% 98.16%
=======================================
Files 473 473
Lines 37770 37777 +7
=======================================
+ Hits 37075 37083 +8
+ Misses 695 694 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
Swatinem
force-pushed
the
swatinem/v1-report-mismatch
branch
from
afdef97 to
c08ee10
Compare
We are capturing a couple internal errors where the
VersionOneReportParsertries to json-parse something that is not JSON.In particular, this event shows that the reportfile contents look rather like a
Legacyformat: https://codecov.sentry.io/issues/5258384165/events/1c65937e66614ec5b5f56743c3d42132/To make this more bulletproof, this will now check that the format "looks like" JSON when choosing the parser, before it actually tries to fully json-parse the contents.
Fixes WORKER-MMH