Move fetch_commit_yaml_and_possibly_store to services.repository
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.01%
==========================================
Files 431 431
Lines 36093 36073 -20
==========================================
- Hits 35219 35205 -14
+ Misses 874 868 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.01%
==========================================
Files 431 431
Lines 36093 36073 -20
==========================================
- Hits 35219 35205 -14
+ Misses 874 868 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 97.57% 97.59% +0.01%
==========================================
Files 431 431
Lines 36093 36073 -20
==========================================
- Hits 35219 35205 -14
+ Misses 874 868 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #604 +/- ##
==========================================
+ Coverage 97.61% 97.63% +0.01%
==========================================
Files 466 466
Lines 37299 37279 -20
==========================================
- Hits 36411 36397 -14
+ Misses 888 882 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
giovanni-guidini
approved these changes
Aug 9, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was copy-pasted across two different classes although it was not depending on any
selfclass members.The function is deduplicated and moved to a different place, along with its tests.
This PR was extracted from #592, as its a simple standalone change.