Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update shared #603

Merged
merged 2 commits into from
Aug 9, 2024
Merged

update shared #603

merged 2 commits into from
Aug 9, 2024

Conversation

giovanni-guidini
Copy link
Contributor

@giovanni-guidini giovanni-guidini commented Aug 9, 2024 •
edited
Loading

I am particularly interested in deploying this change so we (hopefully) process the YAMLs correctly

@giovanni-guidini giovanni-guidini requested a review from a team August 9, 2024 09:40
@codecov-staging
Copy link

codecov-staging bot commented Aug 9, 2024 •
edited by codecov-notifications bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   97.56%   97.59%   +0.02%     
==========================================
  Files         429      431       +2     
  Lines       35958    36073     +115     
==========================================
+ Hits        35084    35205     +121     
+ Misses        874      868       -6
Flag Coverage Δ
integration 97.59% <ø> (+0.02%) ⬆️
latest-uploader-overall 97.59% <ø> (+0.02%) ⬆️
unit 97.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <ø> (+0.05%) ⬆️
OutsideTasks 97.82% <ø> (+0.01%) ⬆️

see 12 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (f969cdb) to head (ffdc9f9).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   97.56%   97.59%   +0.02%     
==========================================
  Files         429      431       +2     
  Lines       35958    36073     +115     
==========================================
+ Hits        35084    35205     +121     
+ Misses        874      868       -6
Flag Coverage Δ
integration 97.59% <ø> (+0.02%) ⬆️
latest-uploader-overall 97.59% <ø> (+0.02%) ⬆️
unit 97.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <ø> (+0.05%) ⬆️
OutsideTasks 97.82% <ø> (+0.01%) ⬆️

see 12 files with indirect coverage changes

@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.66%. Comparing base (f969cdb) to head (ffdc9f9).
Report is 3 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   97.61%   97.66%   +0.05%     
==========================================
  Files         464      466       +2     
  Lines       37164    38148     +984     
==========================================
+ Hits        36276    37256     +980     
- Misses        888      892       +4
Flag Coverage Δ
integration 97.59% <ø> (+0.02%) ⬆️
latest-uploader-overall 97.59% <ø> (+0.02%) ⬆️
unit 97.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.93% <ø> (+0.12%) ⬆️
OutsideTasks 97.82% <ø> (+0.01%) ⬆️

see 12 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (f969cdb) to head (ffdc9f9).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   97.56%   97.59%   +0.02%     
==========================================
  Files         429      431       +2     
  Lines       35958    36073     +115     
==========================================
+ Hits        35084    35205     +121     
+ Misses        874      868       -6
Flag Coverage Δ
integration 97.59% <ø> (+0.02%) ⬆️
latest-uploader-overall 97.59% <ø> (+0.02%) ⬆️
unit 97.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.78% <ø> (+0.05%) ⬆️
OutsideTasks 97.82% <ø> (+0.01%) ⬆️

see 12 files with indirect coverage changes

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit 13e7e28 Aug 9, 2024
26 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/upgrade-shared branch August 9, 2024 11:37
@giovanni-guidini giovanni-guidini mentioned this pull request Aug 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovanni-guidini @Swatinem