Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improve tracing #602

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Slightly improve tracing #602

merged 1 commit into from
Aug 9, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Aug 9, 2024

This adds a bunch of instrumentation to Archive as well as add some Sentry tags to each Celery Task.

This adds a bunch of instrumentation to `Archive` as well as add some Sentry tags to each Celery Task.
@Swatinem Swatinem self-assigned this Aug 9, 2024
@Swatinem Swatinem requested a review from a team August 9, 2024 08:56
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   97.56%   97.57%           
=======================================
  Files         429      429           
  Lines       35958    35950    -8     
=======================================
- Hits        35084    35077    -7     
+ Misses        874      873    -1     
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 90.14% <100.00%> (+0.58%) ⬆️
services/archive.py 90.75% <100.00%> (-0.59%) ⬇️
tasks/base.py 96.15% <ø> (+0.45%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (f969cdb) to head (dc5ff9d).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   97.56%   97.57%           
=======================================
  Files         429      429           
  Lines       35958    35950    -8     
=======================================
- Hits        35084    35077    -7     
+ Misses        874      873    -1     
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 90.14% <100.00%> (+0.58%) ⬆️
services/archive.py 90.75% <100.00%> (-0.59%) ⬇️
tasks/base.py 96.15% <ø> (+0.45%) ⬆️

Copy link

codecov-public-qa bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (f969cdb) to head (dc5ff9d).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   97.56%   97.57%           
=======================================
  Files         429      429           
  Lines       35958    35950    -8     
=======================================
- Hits        35084    35077    -7     
+ Misses        874      873    -1     
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py 90.14% <100.00%> (+0.58%) ⬆️
services/archive.py 90.75% <100.00%> (-0.59%) ⬇️
tasks/base.py 96.15% <ø> (+0.45%) ⬆️

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.61%. Comparing base (f969cdb) to head (dc5ff9d).

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files         464      464           
  Lines       37164    37156    -8     
=======================================
- Hits        36276    36269    -7     
+ Misses        888      887    -1     
Flag Coverage Δ
integration 97.57% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 97.57% <100.00%> (+<0.01%) ⬆️
unit 97.57% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.81% <100.00%> (+<0.01%) ⬆️
OutsideTasks 97.80% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
helpers/telemetry.py Critical 91.78% <100.00%> (+0.47%) ⬆️
services/archive.py Critical 90.83% <100.00%> (-0.58%) ⬇️
tasks/base.py Critical 96.15% <ø> (+0.45%) ⬆️
Related Entrypoints
run/app.tasks.bundle_analysis.BundleAnalysisProcessor
run/app.tasks.upload.Upload
run/app.tasks.status.SetError
run/app.tasks.notify.Notify
run/app.tasks.timeseries.save_commit_measurements
run/app.tasks.profiling.normalizer
run/app.tasks.pulls.Sync
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.upload.UploadFinisher
run/app.tasks.upload.UploadProcessor
run/app.tasks.commit_update.CommitUpdate
run/app.tasks.upload.PreProcessUpload
run/app.tasks.profiling.collection
run/app.tasks.upload.ParallelVerification
run/app.tasks.sync_repo_languages_gql.SyncLanguagesGQL
run/app.tasks.bundle_analysis.BundleAnalysisNotify
run/app.tasks.test_results.TestResultsFinisherTask
run/app.tasks.sync_repo_languages.SyncLanguages
run/app.cron.profiling.findinguncollected
run/app.tasks.profiling.summarization
run/app.tasks.static_analysis.check_suite
run/app.tasks.sync_repos.SyncRepos
run/app.cron.hourly_check.HourlyCheckTask
run/app.tasks.test_results.TestResultsProcessor
run/app.tasks.new_user_activated.NewUserActivated
run/app.tasks.sync_teams.SyncTeams
run/app.tasks.timeseries.backfill_commits
run/app.cron.plan.TrialExpirationCronTask
run/app.cron.daily.GitHubAppWebhooksCheckTask
run/app.tasks.timeseries.backfill_dataset
run/app.tasks.label_analysis.process_request
run/app.tasks.flush_repo.FlushRepo
run/app.tasks.upload.ManualUploadCompletionTrigger
run/app.cron.daily.BrollyStatsRollupTask

@Swatinem Swatinem added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit ebfe076 Aug 9, 2024
25 of 26 checks passed
@Swatinem Swatinem deleted the swatinem/improve-tracing branch August 9, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants