Remove django-admin from requirements
#599
Conversation
The problem is that `django-admin` transitively pulls in `screen`, which does not compile with Python 3.12 due to relying on removed API. This way, it is possible to set up a local `.venv` and install all requirements into it, which thus provides proper editor completions and type hints.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 429 429
Lines 35951 35951
=======================================
Hits 35079 35079
Misses 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 429 429
Lines 35951 35951
=======================================
Hits 35079 35079
Misses 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 429 429
Lines 35951 35951
=======================================
Hits 35079 35079
Misses 872 872
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 464 464
Lines 37157 37157
=======================================
Hits 36271 36271
Misses 886 886
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
The problem is that
django-admintransitively pulls inscreen, which does not compile with Python 3.12 due to relying on removed API. This way, it is possible to set up a local.venvand install all requirements into it, which thus provides proper editor completions and type hints.This complements codecov/shared#318, although I did not add the
.envrc, as that is explicitly ignored.The disclaimer from the other PR is also true here: I don’t really consider myself a Python developer, so I’m not entirely sure what I am doing here.