Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django and Setuptools #595

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

michelletran-codecov
Copy link
Contributor

This upgrades worker to have dependencies that don't depend on distutils. Also, we want to upgrade Django to 4.2.15 because there are several security concerns:

GHSA-f6f8-9mx6-9mx2
GHSA-x7q2-wr7g-xqmf
GHSA-9jmf-237g-qf46

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

This upgrades `worker` to have dependencies that don't depend on `distutils`.
Also, we want to upgrade Django to 4.2.15 because there are several security concerns:

GHSA-f6f8-9mx6-9mx2
GHSA-x7q2-wr7g-xqmf
GHSA-9jmf-237g-qf46
@michelletran-codecov michelletran-codecov force-pushed the upgrade_django_setuptools branch from 06c110a to 81a3129 Compare August 7, 2024 14:41
@codecov-notifications
Copy link

codecov-notifications bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         429      429           
  Lines       35757    35757           
=======================================
  Hits        34885    34885           
  Misses        872      872           
Flag Coverage Δ
integration 97.56% <ø> (ø)
latest-uploader-overall 97.56% <ø> (ø)
unit 97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.71% <ø> (ø)
OutsideTasks 97.80% <ø> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (09db746) to head (81a3129).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         429      429           
  Lines       35757    35757           
=======================================
  Hits        34885    34885           
  Misses        872      872           
Flag Coverage Δ
integration 97.56% <ø> (ø)
latest-uploader-overall 97.56% <ø> (ø)
unit 97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.71% <ø> (ø)
OutsideTasks 97.80% <ø> (ø)

Copy link

codecov-public-qa bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (09db746) to head (81a3129).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         429      429           
  Lines       35757    35757           
=======================================
  Hits        34885    34885           
  Misses        872      872           
Flag Coverage Δ
integration 97.56% <ø> (ø)
latest-uploader-overall 97.56% <ø> (ø)
unit 97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.71% <ø> (ø)
OutsideTasks 97.80% <ø> (ø)

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.60%. Comparing base (09db746) to head (81a3129).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files         464      464           
  Lines       36963    36963           
=======================================
  Hits        36077    36077           
  Misses        886      886           
Flag Coverage Δ
integration 97.56% <ø> (ø)
latest-uploader-overall 97.56% <ø> (ø)
unit 97.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.79% <ø> (ø)
OutsideTasks 97.80% <ø> (ø)

This change has been scanned for critical changes. Learn more

@michelletran-codecov michelletran-codecov marked this pull request as ready for review August 7, 2024 14:54
@michelletran-codecov michelletran-codecov requested a review from a team August 7, 2024 14:54
@michelletran-codecov michelletran-codecov added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 22b1483 Aug 7, 2024
38 of 39 checks passed
@michelletran-codecov michelletran-codecov deleted the upgrade_django_setuptools branch August 7, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants