fix: bring back Owner.integration_id check #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it aims to revert the important bits on f58a5a0 That commit was released and we saw an immediate increase in errors of `RepoWithoutValidBot`. We suspect that it was not correct to remove the deprecated path just yet.
joseph-sentry
approved these changes
May 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 409 409
Lines 33952 33954 +2
=======================================
+ Hits 33051 33053 +2
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 97.34% 97.34%
=======================================
Files 409 409
Lines 33952 33954 +2
=======================================
+ Hits 33051 33053 +2
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #466 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 441 441
Lines 34707 34709 +2
=======================================
+ Hits 33797 33799 +2
Misses 910 910
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it aims to revert the important bits on f58a5a0
That commit was released and we saw an immediate increase in errors of
RepoWithoutValidBot.We suspect that it was not correct to remove the deprecated path just yet.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.