Rework backfill task to create sub-tasks #465
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage ? 97.25%
=======================================
Files ? 409
Lines ? 33974
Branches ? 0
=======================================
Hits ? 33040
Misses ? 934
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 97.34% 97.25% -0.10%
==========================================
Files 409 409
Lines 33954 33976 +22
==========================================
- Hits 33053 33042 -11
- Misses 901 934 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 97.37% 97.28% -0.10%
==========================================
Files 441 441
Lines 34709 34731 +22
==========================================
- Hits 33799 33788 -11
- Misses 910 943 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 97.34% 97.25% -0.10%
==========================================
Files 409 409
Lines 33954 33976 +22
==========================================
- Hits 33053 33042 -11
- Misses 901 934 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -107,7 +107,9 @@ def init_celery_tracing(*args, **kwargs): | |||
|
|
|||
| # Backfill GH Apps | |||
| backfill_existing_gh_app_installations_name = "app.tasks.backfill_existing_gh_app_installations.BackfillExistingGHAppInstallationsTask" | |||
| backfill_existing_individual_gh_app_installation_name = "app.tasks.backfill_existing_individual_gh_app_installation.BackfillExistingIndividualGHAppInstallationTask" | |||
There was a problem hiding this comment.
this is more for future reference, but very nit
The task name is (or should be) formatted as
app.[tasks|cron].<TaskConfigGroup>.<task name>
so all of the tasks in the backfill could have the same of backfill or backfil_github_apps, for example. This makes it easier for us to know what tasks are related.
There was a problem hiding this comment.
Ty for this! That honestly makes a lot more sense 🙏
This just reworks the existing GH app backfill task to distribute the backfill to subtasks. Previous implementation seemed to run out of memory, hence making several subtasks.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.