Bundle analysis handle rate limit error #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 97.34% 97.35%
=======================================
Files 401 401
Lines 33638 33665 +27
=======================================
+ Hits 32746 32773 +27
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 97.34% 97.35%
=======================================
Files 401 401
Lines 33638 33665 +27
=======================================
+ Hits 32746 32773 +27
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 97.34% 97.35%
=======================================
Files 401 401
Lines 33638 33665 +27
=======================================
+ Hits 32746 32773 +27
Misses 892 892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 432 432
Lines 34328 34355 +27
=======================================
+ Hits 33427 33454 +27
Misses 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
adrian-codecov
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 of 2 PRs of the fix.
When encountering a rate limit error by GCS when doing save file to the BA bucket, instead of failing the processor step completely, it will now retry.
GCS has a 1 PUT request per second rate limit when updating an existing object in storage, the BA processor may encounter this edge case when multiple BA processing tasks are running in parallel to update multiple bundle stats files. And when this is encountered, we don't update the SQLite file for this stats file therefore causing incorrect data. This fix will retry the task after a short 20s cooldown to once again attempt to upload, at this time most likely the rate limit threshold would be passed. Note that there can still be cases when multiple retried tasks run at the same time again, but the probability of this would be really low considering the existing issue of rate limiting error from GCS is also seen very rarely.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.