-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small correction to welcome message logic #431
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 97.34% 97.40% +0.06%
==========================================
Files 399 398 -1
Lines 33723 33658 -65
==========================================
- Hits 32827 32786 -41
+ Misses 896 872 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found @@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 97.34% 97.40% +0.06%
==========================================
Files 399 398 -1
Lines 33723 33658 -65
==========================================
- Hits 32827 32786 -41
+ Misses 896 872 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
+ Coverage 97.37% 97.43% +0.06%
==========================================
Files 430 429 -1
Lines 34414 34349 -65
==========================================
- Hits 33509 33468 -41
+ Misses 905 881 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes This change has been scanned for critical changes. Learn more |
follows up #430
missed one detail from this request codecov/engineering-team#1683