Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small correction to welcome message logic #431

Merged
merged 4 commits into from
May 6, 2024
Merged

small correction to welcome message logic #431

merged 4 commits into from
May 6, 2024

Conversation

nora-codecov
Copy link
Contributor

follows up #430
missed one detail from this request codecov/engineering-team#1683

@codecov-qa
Copy link

codecov-qa bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (2485119) to head (7deecd6).

❗ Current head 7deecd6 differs from pull request most recent head 3f1fe97. Consider uploading reports for the commit 3f1fe97 to get more accurate results

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   97.34%   97.40%   +0.06%     
==========================================
  Files         399      398       -1     
  Lines       33723    33658      -65     
==========================================
- Hits        32827    32786      -41     
+ Misses        896      872      -24     
Flag Coverage Δ
integration 97.40% <100.00%> (+0.06%) ⬆️
latest-uploader-overall 97.40% <100.00%> (+0.06%) ⬆️
unit 97.40% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <100.00%> (+0.16%) ⬆️
OutsideTasks 97.49% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.48% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.22% <100.00%> (+<0.01%) ⬆️

... and 7 files with indirect coverage changes

Copy link

codecov-public-qa bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (2485119) to head (7deecd6).

❗ Current head 7deecd6 differs from pull request most recent head 3f1fe97. Consider uploading reports for the commit 3f1fe97 to get more accurate results

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   97.34%   97.40%   +0.06%     
==========================================
  Files         399      398       -1     
  Lines       33723    33658      -65     
==========================================
- Hits        32827    32786      -41     
+ Misses        896      872      -24     
Flag Coverage Δ
integration 97.40% <100.00%> (+0.06%) ⬆️
latest-uploader-overall 97.40% <100.00%> (+0.06%) ⬆️
unit 97.40% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <100.00%> (+0.16%) ⬆️
OutsideTasks 97.49% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.48% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.22% <100.00%> (+<0.01%) ⬆️

... and 7 files with indirect coverage changes

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (2485119) to head (7deecd6).

❗ Current head 7deecd6 differs from pull request most recent head 3f1fe97. Consider uploading reports for the commit 3f1fe97 to get more accurate results

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   97.37%   97.43%   +0.06%     
==========================================
  Files         430      429       -1     
  Lines       34414    34349      -65     
==========================================
- Hits        33509    33468      -41     
+ Misses        905      881      -24     
Flag Coverage Δ
integration 97.40% <100.00%> (+0.06%) ⬆️
latest-uploader-overall 97.40% <100.00%> (+0.06%) ⬆️
unit 97.40% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.75% <100.00%> (+0.16%) ⬆️
OutsideTasks 97.49% <100.00%> (-0.01%) ⬇️
Files Coverage Δ
...ervices/notification/notifiers/comment/__init__.py 99.48% <100.00%> (ø)
.../notification/notifiers/tests/unit/test_comment.py 99.27% <100.00%> (+<0.01%) ⬆️

... and 7 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

adrian-codecov
adrian-codecov previously approved these changes May 6, 2024
@nora-codecov nora-codecov added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 5be9dcb May 6, 2024
12 of 13 checks passed
@nora-codecov nora-codecov deleted the nora/1683 branch May 6, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants