Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: if timescale is down don't crash #420

Merged
merged 1 commit into from
May 2, 2024

Conversation

joseph-sentry
Copy link
Contributor

@joseph-sentry joseph-sentry commented Apr 29, 2024

@codecov-qa
Copy link

codecov-qa bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.43%. Comparing base (f64dc25) to head (40884ff).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   97.44%   97.43%   -0.01%     
==========================================
  Files         395      395              
  Lines       33430    33436       +6     
==========================================
+ Hits        32577    32580       +3     
- Misses        853      856       +3     
Flag Coverage Δ
integration 97.43% <42.85%> (-0.01%) ⬇️
latest-uploader-overall 97.43% <42.85%> (-0.01%) ⬇️
unit 97.43% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <42.85%> (-0.02%) ⬇️
OutsideTasks 97.54% <42.85%> (-0.02%) ⬇️
Files Coverage Δ
helpers/telemetry.py 92.40% <42.85%> (-3.49%) ⬇️

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.46%. Comparing base (f64dc25) to head (b8ccd0c).

❗ Current head b8ccd0c differs from pull request most recent head 40884ff. Consider uploading reports for the commit 40884ff to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   97.47%   97.46%   -0.02%     
==========================================
  Files         426      426              
  Lines       34121    34123       +2     
==========================================
- Hits        33259    33257       -2     
- Misses        862      866       +4     
Flag Coverage Δ
integration 97.43% <42.85%> (-0.02%) ⬇️
latest-uploader-overall 97.43% <42.85%> (-0.02%) ⬇️
unit 97.43% <42.85%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.75% <42.85%> (-0.03%) ⬇️
OutsideTasks 97.53% <42.85%> (-0.02%) ⬇️
Files Coverage Δ
helpers/telemetry.py Critical 93.82% <42.85%> (-3.51%) ⬇️

... and 4 files with indirect coverage changes

Related Entrypoints
run/app.tasks.pulls.Sync
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.status.SetError
run/app.tasks.timeseries.save_commit_measurements
run/app.tasks.notify.Notify
run/app.tasks.profiling.normalizer
run/app.tasks.commit_update.CommitUpdate
run/app.tasks.upload.Upload
run/app.tasks.sync_repo_languages.SyncLanguages
run/app.tasks.upload.PreProcessUpload
run/app.tasks.upload.UploadFinisher
run/app.tasks.upload.UploadProcessor
run/app.tasks.profiling.summarization
run/app.tasks.static_analysis.check_suite
run/app.tasks.bundle_analysis.BundleAnalysisProcessor
run/app.tasks.upload.ParallelVerification
run/app.cron.daily.GitHubAppWebhooksCheckTask
run/app.tasks.upload.ManualUploadCompletionTrigger
run/app.cron.profiling.findinguncollected
run/app.tasks.sync_repo_languages_gql.SyncLanguagesGQL
run/app.tasks.sync_repos.SyncRepos

Copy link

codecov-public-qa bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 97.43%. Comparing base (f64dc25) to head (40884ff).

✅ All tests successful. No failed tests found ☺️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   97.44%   97.43%   -0.01%     
==========================================
  Files         395      395              
  Lines       33430    33436       +6     
==========================================
+ Hits        32577    32580       +3     
- Misses        853      856       +3     
Flag Coverage Δ
integration 97.43% <42.85%> (-0.01%) ⬇️
latest-uploader-overall 97.43% <42.85%> (-0.01%) ⬇️
unit 97.43% <42.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.73% <42.85%> (-0.02%) ⬇️
OutsideTasks 97.54% <42.85%> (-0.02%) ⬇️
Files Coverage Δ
helpers/telemetry.py 92.40% <42.85%> (-3.49%) ⬇️

@joseph-sentry joseph-sentry force-pushed the joseph/handle-timescale-down branch from b8ccd0c to 40884ff Compare May 1, 2024 20:41
@joseph-sentry joseph-sentry requested review from a team and removed request for matt-codecov May 1, 2024 20:41
@joseph-sentry joseph-sentry added this pull request to the merge queue May 2, 2024
Merged via the queue into main with commit cad2709 May 2, 2024
13 of 21 checks passed
@joseph-sentry joseph-sentry deleted the joseph/handle-timescale-down branch May 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants