Failed check and status messaging in comment, part VI #1055
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1055 +/- ##
=======================================
Coverage 97.52% 97.52%
=======================================
Files 462 462
Lines 37902 37908 +6
=======================================
+ Hits 36963 36969 +6
Misses 939 939
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
| INDIRECT_CHANGES_KEY: HELPER_TEXT_MAP[INDIRECT_CHANGES_KEY].format( | ||
| context="changes", notification_type="status" |
There was a problem hiding this comment.
just like with the other text, I would prefer the actual text to be asserted here.
otherwise the test is just a mirror of the code doing the formatting.
when user has:
changes checks notifier OR changes status notifier
AND
comment notifier
AND
the change check/status fails
AND
there are unexpected/indirect changes
THEN
add some helper text to the comment notifier to point out that the check/status failed, with links to docs
codecov/engineering-team#1627