Skip to content

Commit

Permalink
Remove double-async_to_sync (#672)
Browse files Browse the repository at this point in the history
  • Loading branch information
Swatinem authored Sep 2, 2024
1 parent 40bcec1 commit f8f4c0a
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tasks/upload_finisher.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
from concurrent.futures import ThreadPoolExecutor
from enum import Enum

from asgiref.sync import async_to_sync
from redis.exceptions import LockError
from shared.celery_config import (
compute_comparison_task_name,
Expand Down Expand Up @@ -170,9 +169,9 @@ def run_impl(
)

with metrics.timer(f"{self.metrics_prefix}.save_parallel_report_results"):
parallel_paths = async_to_sync(
report_service.save_parallel_report_to_archive
)(commit, report, report_code)
parallel_paths = report_service.save_parallel_report_to_archive(
commit, report, report_code
)
# now that we've built the report and stored it to GCS, we have what we need to
# compare the results with the current upload pipeline. We end execution of the
# finisher task here so that we don't cause any additional side-effects
Expand Down

0 comments on commit f8f4c0a

Please sign in to comment.