re-export shared bot exceptions instead of redefine them

helpers/exceptions.py

@@ -1,3 +1,11 @@
+import shared.bots.exceptions
+
+RepositoryWithoutValidBotError = shared.bots.exceptions.RepositoryWithoutValidBotError
+OwnerWithoutValidBotError = shared.bots.exceptions.OwnerWithoutValidBotError
+RequestedGithubAppNotFound = shared.bots.exceptions.RequestedGithubAppNotFound
+NoConfiguredAppsAvailable = shared.bots.exceptions.NoConfiguredAppsAvailable
+
+
 class ReportExpiredException(Exception):
     def __init__(self, message=None, filename=None) -> None:
         super().__init__(message)
@@ -8,27 +16,6 @@ class ReportEmptyError(Exception):
     pass
 
 
-class RepositoryWithoutValidBotError(Exception):
-    pass
-
-
-class RequestedGithubAppNotFound(Exception):
-    pass
-
-
-class OwnerWithoutValidBotError(Exception):
-    pass
-
-
-class NoConfiguredAppsAvailable(Exception):
-    def __init__(
-        self, apps_count: int, rate_limited_count: int, suspended_count: int
-    ) -> None:
-        self.apps_count = apps_count
-        self.rate_limited_count = rate_limited_count
-        self.suspended_count = suspended_count
-
-
 class CorruptRawReportError(Exception):
     """Error indicated that report is somehow different than it should be
 

tasks/tests/unit/test_preprocess_upload.py

@@ -8,7 +8,7 @@
     ReportFactory,
     RepositoryFactory,
 )
-from helpers.exceptions import RepositoryWithoutValidBotError
+from helpers.exceptions import OwnerWithoutValidBotError, RepositoryWithoutValidBotError
 from services.report import ReportService
 from tasks.preprocess_upload import PreProcessUpload
 
@@ -216,6 +216,29 @@ def test_run_impl_unobtainable_lock(self, dbsession, mocker, mock_redis):
             "reason": "unable_to_acquire_lock",
         }
 
+    def test_get_repo_service_repo_and_owner_lack_bot(self, dbsession, mocker):
+        def mock_owner(foo):
+            print("in mock owner", foo)
+            raise OwnerWithoutValidBotError()
+
+        mock_owner_bot = mocker.patch(
+            "shared.bots.repo_bots.get_owner_or_appropriate_bot"
+        )
+        mock_owner_bot.side_effect = OwnerWithoutValidBotError()
+
+        mock_github_installations = mocker.patch(
+            "shared.bots.github_apps.get_github_app_info_for_owner"
+        )
+        mock_github_installations.return_value = []
+
+        mock_save_error = mocker.patch("tasks.preprocess_upload.save_commit_error")
+
+        commit = CommitFactory.create(repository__private=True, repository__bot=None)
+        repo_service = PreProcessUpload().get_repo_service(commit, None)
+
+        assert repo_service is None
+        mock_save_error.assert_called()
+
     def test_get_repo_provider_service_no_bot(self, dbsession, mocker):
         mocker.patch("tasks.preprocess_upload.save_commit_error")
         mock_get_repo_service = mocker.patch(