final tweak based on PR comments

codecov · Apr 30, 2024 · 6c2d164 · 6c2d164
1 parent 8b5317b
commit 6c2d164
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/tasks/backfill_existing_gh_app_installations.py b/tasks/backfill_existing_gh_app_installations.py
@@ -69,7 +69,6 @@ def backfill_existing_gh_apps(
                         gh_app_installation=gh_app_installation,
                     )
                     log.info("Successful backfill", extra=dict(ownerid=ownerid))
-                del owner_service
             except:
                 log.info(
                     "Backfill unsuccessful for this owner", extra=dict(ownerid=ownerid)

diff --git a/tasks/backfill_owners_without_gh_app_installations.py b/tasks/backfill_owners_without_gh_app_installations.py
@@ -72,7 +72,7 @@ def backfill_owners_with_integration_without_gh_app(
                     name=GITHUB_APP_INSTALLATION_DEFAULT_NAME,
                 )
                 db_session.add(gh_app_installation)
-                db_session.commit()
+                # db_session.commit()
 
                 is_selection_all = maybe_set_installation_to_all_repos(
                     db_session=db_session,