feat: notif latency with flake detection tag (#594)

codecov · Aug 7, 2024 · 09db746 · 09db746
1 parent c3ba63a
commit 09db746
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/services/test_results.py b/services/test_results.py
@@ -280,15 +280,15 @@ def latest_test_instances_for_a_given_commit(db_session, commit_id):
     )
 
 
-def should_write_flaky_detection(repoid: int, commit_yaml: UserYaml):
+def should_write_flaky_detection(repoid: int, commit_yaml: UserYaml) -> bool:
     return (
         FLAKY_TEST_DETECTION.check_value(identifier=repoid, default=False)
         and read_yaml_field(commit_yaml, ("test_analytics", "flake_detection"), False)
         or FLAKY_SHADOW_MODE.check_value(identifier=repoid, default=False)
     )
 
 
-def should_read_flaky_detection(repoid: int, commit_yaml: UserYaml):
+def should_read_flaky_detection(repoid: int, commit_yaml: UserYaml) -> bool:
     return FLAKY_TEST_DETECTION.check_value(
         identifier=repoid, default=False
     ) and read_yaml_field(commit_yaml, ("test_analytics", "flake_detection"), False)
diff --git a/tasks/test_results_finisher.py b/tasks/test_results_finisher.py
@@ -302,7 +302,10 @@ def process_impl_within_lock(
                     TestResultsFlow.TEST_RESULTS_NOTIFY,
                 ),
                 unit="millisecond",
-                tags={"repoid": repoid},
+                tags={
+                    "repoid": repoid,
+                    "flake_detection": should_read_flaky_detection(repoid, commit_yaml),
+                },
             )
             notifier_result: NotifierResult = async_to_sync(notifier.notify)()